Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@victorbucutea
Copy link

…ScreenLocation()

Description

support for projection toScreenLocation() and fromScreenLocation() + example ui

Related Issues

flutter/flutter#24213.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x ] All existing and new tests are passing.
  • [x ] I updated/added relevant documentation (doc comments with ///).
  • [x ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ x] I read and followed the Flutter Style Guide.
  • [ x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [ x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [] I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@victorbucutea
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@collinjackson collinjackson changed the title #24213 add support for projection toScreenLocation() and fromScreenLocation() [flutter_google_maps] add support for projection toScreenLocation() and fromScreenLocation() Sep 26, 2019
@collinjackson collinjackson changed the title [flutter_google_maps] add support for projection toScreenLocation() and fromScreenLocation() [google_maps_flutter] add support for projection toScreenLocation() and fromScreenLocation() Sep 26, 2019
@otopba
Copy link
Contributor

otopba commented Jan 19, 2020

@victorbucutea
Hi! Could you merge original master to this PR ? Thank you

@sanekyy
Copy link
Contributor

sanekyy commented Feb 1, 2020

@victorbucutea
Hello. You use wrong code style for this project.

You can setup correct code style with google java format plugin.

After this verify changes with flutter_plugin_tools and fix all warnings and errors, please.

You can read about how to do it in contribution guide.

Thank you in advance.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution. However, it appears that this was obsoleted by #2108, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants