Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@Xavjer
Copy link

@Xavjer Xavjer commented Sep 13, 2019

Description

Fixes the issue, that within image_picker when taking a picture on iOS in Portrait mode, the scaling did not work as intended (AspectRatio was flipped)

Related Issues

flutter/flutter#40334 => Will be fixed with this PR

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [(X) ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
    => No new unit tests added, as the existing should already cover this, but the image did not have the values that were returned from the channel.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Xavjer Xavjer requested a review from cyanglaz as a code owner September 13, 2019 16:58
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Xavjer
Copy link
Author

Xavjer commented Sep 13, 2019

@googlebot I fixed it.

@Xavjer
Copy link
Author

Xavjer commented Sep 13, 2019

Reopening due to wrong commiter idenitity

@Xavjer Xavjer closed this Sep 13, 2019
@Xgamefactory
Copy link

issue still on lates version image_picker: ^0.6.1+4

@Xavjer
Copy link
Author

Xavjer commented Sep 19, 2019

@Xgamefactory this PR was not merged, recreated in #2061 but not merged yet, therefore the error still exists

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…tform interface) (flutter#2060)

* Updated `FieldValueFactoryPlatform` to use generics.
* `FieldValuePlatform` no longer extends `PlatformInterface`.
* `MethodChannelFieldValue` no longer extends `FieldValuePlatform` and supports equality comparison.
* Fixed the file name of a test.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants