Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 10, 2019

If using FragmentActivity, the requestCode used for startActivityForResult needs to be below 65536. See https://stackoverflow.com/questions/25529865/java-lang-illegalargumentexception-can-only-use-lower-16-bits-for-requestcode.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim mklim self-assigned this Aug 12, 2019
@mklim mklim added the submit queue The Flutter team is in the process of landing this PR. label Aug 12, 2019
@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 12, 2019

@mklim Not sure what submit queue is. Does it mean I don't take any action and you will merge this in the near future?

@mklim
Copy link
Contributor

mklim commented Aug 13, 2019

@mehmetf yes, I was waiting for CI to finish running before merging. I added a description to the label so it's more obvious.

@mklim mklim merged commit 2b2ca66 into flutter:master Aug 13, 2019
@mehmetf mehmetf deleted the b33 branch September 12, 2019 17:43
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants