Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@josh-burton
Copy link
Contributor

@josh-burton josh-burton commented Jul 30, 2019

…ason when the crash has no context

Description

Seeing lots of crashes related to this issue.

Example crash log:

#0. Crashed: com.apple.main-thread
0  libsystem_platform.dylib       0x1ad46e384 _platform_strlen + 4
1  CoreFoundation                 0x1ad80b5e8 __CFStringAppendFormatCore + 6024
2  CoreFoundation                 0x1ad80d6b8 _CFStringCreateWithFormatAndArgumentsAux2 + 136
3  Foundation                     0x1ae1b6790 +[NSString stringWithFormat:] + 68
4  Runner                         0x100fa2608 -[FirebaseCrashlyticsPlugin handleMethodCall:result:] + 81 (FirebaseCrashlyticsPlugin.m:81)

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@josh-burton josh-burton force-pushed the crashlytics-context-crash branch from d28e193 to 631239e Compare July 30, 2019 00:56
@kroikie kroikie changed the title [firebase-crashlytics] Fixes exception when trying to format crash re… [firebase_crashlytics] Fixes exception when trying to format crash re… Jul 30, 2019
@kroikie
Copy link
Contributor

kroikie commented Jul 30, 2019

@athornz Thanks for the PR, could you update the description so it shows the error you are seeing when submitting reports?

@josh-burton
Copy link
Contributor Author

@kroikie done!

@kroikie
Copy link
Contributor

kroikie commented Jul 30, 2019

Once build passes I'll merge.

@kroikie kroikie added the submit queue The Flutter team is in the process of landing this PR. label Jul 30, 2019
@collinjackson collinjackson merged commit 8030246 into flutter:master Jul 30, 2019
@josh-burton josh-burton deleted the crashlytics-context-crash branch July 30, 2019 03:03
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes flutterfire submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants