Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jul 28, 2019

Description

Avoids an exception when additionalProviderInfo is nil or has nil fields.

Related Issues

Fixes flutter/flutter#37133

This is already tested by our integration tests, but our test CI isn't failing on exceptions that kill the app on iOS, which is how this slipped through. Once that is fixed, test failures like this will prevent PRs from being merged. (flutter/flutter#37141, https://github.com/flutter/plugin_tools/pull/50)

For the moment we can confirm that the test failure is fixed by just looking at the test logs.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson collinjackson changed the title Fixes exceptions when signing in on iOS with firebase_auth 0.12. [firebase_auth] Fixes exceptions when signing in on iOS Jul 28, 2019
Copy link
Contributor

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@collinjackson collinjackson merged commit c92d2f2 into flutter:master Jul 28, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
* Fixes exceptions when signing in on iOS

* Update test results to reflect different behavior on iOS and Android

* Sign out at the start of tests
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Fixes exceptions when signing in on iOS

* Update test results to reflect different behavior on iOS and Android

* Sign out at the start of tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash using firebase_auth 0.12 username/password login (previous version works fine)

3 participants