This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_auth] fix inconsistency between iOS and Android on FirebaseUserMetadata #1919
Merged
collinjackson
merged 12 commits into
flutter:master
from
long1eu:fix_ios_auth_inconsistancy
Jul 29, 2019
Merged
[firebase_auth] fix inconsistency between iOS and Android on FirebaseUserMetadata #1919
collinjackson
merged 12 commits into
flutter:master
from
long1eu:fix_ios_auth_inconsistancy
Jul 29, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on `FirebaseUserMetadata`
Contributor
|
This is a breaking change to the behavior and we're doing some other breaking changes to the library right now (see #1911) so I think it's a good time to update these method names and have them return a |
collinjackson
approved these changes
Jul 27, 2019
13 tasks
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…UserMetadata (flutter#1919) * [firebase_auth] fix inconsistency between iOS and Android on `FirebaseUserMetadata` * Update to `creationTime` and `lastSignInTime`
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…UserMetadata (flutter#1919) * [firebase_auth] fix inconsistency between iOS and Android on `FirebaseUserMetadata` * Update to `creationTime` and `lastSignInTime`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On iOS
creationTimestampandlastSignInTimestampwere return in seconds and on Android in milliseconds. Now both platforms return those valuesin milliseconds(edit: as aDateTime).Related Issues
flutter/flutter#27986
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?