Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@long1eu
Copy link
Contributor

@long1eu long1eu commented Jul 27, 2019

Related Issues

flutter/flutter#16432

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

# Conflicts:
#	packages/cloud_firestore/CHANGELOG.md
@long1eu
Copy link
Contributor Author

long1eu commented Jul 27, 2019

It's a bit strange. I'm running pub global activate flutter_plugin_tools && pub global run flutter_plugin_tools format but I get a different result than the one from cirrus.

The difference was on the flutter version, I used the stable channel.

@long1eu long1eu changed the title [WIP][cloud_firestore] add support for MetadataChanges [cloud_firestore] add support for MetadataChanges Jul 27, 2019
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This can be done more idiomatically in Dart using a boolean optional named argument. I've pushed a change to your PR.

This change needs an integration test in addition to the unit test.

@long1eu long1eu changed the title [cloud_firestore] add support for MetadataChanges [WIP][cloud_firestore] add support for MetadataChanges Jul 28, 2019
@long1eu long1eu changed the title [WIP][cloud_firestore] add support for MetadataChanges [cloud_firestore] add support for MetadataChanges Jul 28, 2019
@collinjackson
Copy link
Contributor

Thanks for the PR! LGTM

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@long1eu
Copy link
Contributor Author

long1eu commented Jul 29, 2019

Do you want me to fix this? Also please make sure to assign me 2 issues each week. I prefer the ones related to plugins. :D

@collinjackson
Copy link
Contributor

collinjackson commented Jul 29, 2019

I think I fixed the test. Do you have any feedback/changes you want to make before I merge this?

Generally we try prioritize PRs that are associated with issues that have a lot of thumbs. Feel free to reach out to me on Gitter or via my email [email protected] for advice on issue prioritization.

Here are some auth issues you might consider taking on:

@long1eu
Copy link
Contributor Author

long1eu commented Jul 29, 2019

LGTM, also I can take flutter/flutter#35974

@collinjackson
Copy link
Contributor

LGTM, also I can take flutter/flutter#35974

Great, thank you. I put a few other issue ideas in the list above.

@collinjackson collinjackson merged commit 8b786d4 into flutter:master Jul 29, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
* [cloud_firestore] add support for MetadataChanges

* test: add integration test for metadata changes
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* [cloud_firestore] add support for MetadataChanges

* test: add integration test for metadata changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants