-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[cloud_firestore] add support for MetadataChanges #1918
Conversation
# Conflicts: # packages/cloud_firestore/CHANGELOG.md
|
It's a bit strange. I'm running The difference was on the flutter version, I used the stable channel. |
collinjackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This can be done more idiomatically in Dart using a boolean optional named argument. I've pushed a change to your PR.
This change needs an integration test in addition to the unit test.
This reverts commit 095ea23.
|
Thanks for the PR! LGTM |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Do you want me to fix this? Also please make sure to assign me 2 issues each week. I prefer the ones related to plugins. :D |
|
I think I fixed the test. Do you have any feedback/changes you want to make before I merge this? Generally we try prioritize PRs that are associated with issues that have a lot of thumbs. Feel free to reach out to me on Gitter or via my email [email protected] for advice on issue prioritization. Here are some auth issues you might consider taking on:
|
|
LGTM, also I can take flutter/flutter#35974 |
Great, thank you. I put a few other issue ideas in the list above. |
* [cloud_firestore] add support for MetadataChanges * test: add integration test for metadata changes
* [cloud_firestore] add support for MetadataChanges * test: add integration test for metadata changes
Related Issues
flutter/flutter#16432
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?