Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@lsaudon
Copy link

@lsaudon lsaudon commented Jul 26, 2019

Description

Wrong method

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@creativecreatorormaybenot
Copy link
Contributor

creativecreatorormaybenot commented Jul 26, 2019

@lsaudon Are you ok with me integrating this into #1912? I will add that change and then you can decide if you want to close this PR or not.

Every single update needs a version bump and a changelog entry, so it would slow down merging the PRs.

@lsaudon
Copy link
Author

lsaudon commented Jul 26, 2019

No problem i can close my PR

@lsaudon lsaudon closed this Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants