Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Enable --stacktrace by default for the Android all_plugins example #1904

Merged
collinjackson merged 3 commits into from
Aug 1, 2019
Merged

Enable --stacktrace by default for the Android all_plugins example #1904

collinjackson merged 3 commits into from
Aug 1, 2019

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jul 25, 2019 •
edited
Loading

Might help more quickly diagnose build failures, e.g.

Gradle task assembleAarRelease failed with exit code 1
FAILURE: Build failed with an exception.
* Where:
Script '/home/cirrus/sdks/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 946
* What went wrong:
Execution failed for task ':app:buildPluginReleaseInAppPurchase'.
> Process 'command '/home/cirrus/sdks/flutter/bin/flutter'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org

https://cirrus-ci.com/task/6303567802007552

@collinjackson collinjackson requested review from amirh and mklim July 25, 2019 20:54
@collinjackson collinjackson changed the title Enable stack traces by default for the all plugins example. Enable --stacktrace by default for the Android all_plugins example Jul 25, 2019
mklim
mklim reviewed Jul 25, 2019
View reviewed changes
mklim
mklim approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@collinjackson collinjackson merged commit 0472d05 into flutter:master Aug 1, 2019
@collinjackson collinjackson deleted the stacktrace branch August 1, 2019 21:56
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
@collinjackson @mithun-mondal
Enable --stacktrace by default for the Android all_plugins example (f…
9856ed3 
…lutter#1904)

* Enable stack traces by default for the all_plugins example
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amirh amirh Awaiting requested review from amirh

1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@collinjackson @mklim @googlebot