Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_alarm_manager] Added support for setting alarms which work when the phone is in doze mode #1895

Merged
bkonyi merged 2 commits into from
Jul 24, 2019
Merged

[android_alarm_manager] Added support for setting alarms which work when the phone is in doze mode #1895

bkonyi merged 2 commits into from
Jul 24, 2019

Conversation

@brouxco
Copy link
Contributor

@brouxco brouxco commented Jul 23, 2019 •
edited
Loading

Description

Added support for setting alarms which work when the phone is in doze mode

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@brouxco brouxco requested a review from bkonyi as a code owner July 23, 2019 14:35
@brouxco brouxco changed the title Added support for setting alarms which work when the phone is in doje Added support for setting alarms which work when the phone is in doze mode Jul 23, 2019
@brouxco brouxco changed the title Added support for setting alarms which work when the phone is in doze mode [android_alarm_manager] Added support for setting alarms which work when the phone is in doze mode Jul 23, 2019
bkonyi
bkonyi approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR!

@bkonyi bkonyi merged commit d0e798f into flutter:master Jul 24, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
@brouxco @mithun-mondal
[android_alarm_manager] Added support for setting alarms which work w…
5e53149 
…hen the phone is in doze mode (flutter#1895)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bkonyi bkonyi bkonyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brouxco @bkonyi @googlebot @bparrishMines