This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[camera] Dart side of camera API #1889
Merged
bparrishMines
merged 6 commits into
flutter:master
from
bparrishMines:support_android_dart
Jul 26, 2019
Merged
[camera] Dart side of camera API #1889
bparrishMines
merged 6 commits into
flutter:master
from
bparrishMines:support_android_dart
Jul 26, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Jul 22, 2019
| /// Information about a camera. | ||
| /// | ||
| /// Retrieved from [Camera.getCameraInfo]. | ||
| class CameraInfo implements CameraDescription { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bparrishMines
commented
Jul 22, 2019
| /// This exposes the deprecated Android | ||
| /// [Camera](https://developer.android.com/reference/android/hardware/Camera) | ||
| /// API. This should only be used with Android sdk versions less than 21. | ||
| class Camera with NativeMethodCallHandler { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mklim
approved these changes
Jul 22, 2019
Contributor
mklim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit.
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the dart side of the Camera API for Android. It will be for support Android versions of 16-21.
Related Issues
flutter/flutter#31225
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?