This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_performance] Fix invokeMethod formatting that caused a bug with Dart code obfuscation #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
collinjackson
left a comment
collinjackson
left a comment
There was a problem hiding this comment.
Thanks for the fix! A few minor nits and then I'm happy to merge this.
packages/firebase_performance/android/.settings/org.eclipse.buildship.core.prefs
Outdated
Show resolved
Hide resolved
packages/firebase_performance/example/android/.settings/org.eclipse.buildship.core.prefs
Outdated
Show resolved
Hide resolved
axel-op
commented
Jul 18, 2019
Contributor
Author
axel-op
left a comment
axel-op
left a comment
There was a problem hiding this comment.
@collinjackson I made the changes you asked for.
collinjackson
approved these changes
Jul 18, 2019
axel-op
referenced
this pull request
Jul 20, 2019
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…with Dart code obfuscation (flutter#1874) * Fix invokeMethod formatting that caused a bug with Dart code obfuscation
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…with Dart code obfuscation (flutter#1874) * Fix invokeMethod formatting that caused a bug with Dart code obfuscation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Formatting used with
invokeMethod, with a$symbol before the class name (e.g.$ClassName#MethodName), caused the replacement of the class name during Dart code obfuscation, and broke the link with the corresponding method on the native side.This has been resolved by removing the
$symbols.Related Issues
flutter/flutter#35764 fixed
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?