Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@juliocbcotta
Copy link
Contributor

Description

Updates ExoPlayer for Android
https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

- updated changelog and pubspec
@cyanglaz
Copy link
Contributor

cyanglaz commented Jul 17, 2019

Thanks for the contribution!
Updating the ExoPlayer can be risky as we don't yet have any integration tests for this plugin.

I'm following the initial PR review policy, this PR isn't trivial to review so I'm labeling it with "backlog" and we will prioritize according to the issue's priority.

related issue: flutter/flutter#36375

@juliocbcotta
Copy link
Contributor Author

@cyanglaz What tests do we need? I can give it a try if we have a sample in the plugins repository.

@ened
Copy link
Contributor

ened commented Oct 9, 2019

HI @BugsBunnyBR could you please update the PR to include ExoPlayer 2.10.5 ?

@juliocbcotta
Copy link
Contributor Author

HI @BugsBunnyBR could you please update the PR to include ExoPlayer 2.10.5 ?

I will do it latter today.

@juliocbcotta juliocbcotta changed the title [video_player] updated ExoPlayer Android to version 2.10.3 [video_player] updated ExoPlayer Android to version 2.10.5 Oct 10, 2019
@cbenhagen
Copy link
Contributor

Thank you for your contribution! Unfortunately the structure of the plugin has changed lately to support implementations on more platforms. Mainly the plugin was moved to a new subdirectory and now uses a common platform interface. Adapting your PR to the new structure should be straight forward. If you have questions please ask!

I guess the version could be bumped to 2.10.8.

@juliocbcotta
Copy link
Contributor Author

I am closing this pr as it has not been merged until this date even though I kept it updated upon the team request I am no longer doing this.
This behaviour from the developers show a lack of respect with people trying to offer help.

@cbenhagen
Copy link
Contributor

cbenhagen commented Dec 9, 2019

@BugsBunnyBR I totally understand your frustration. Things are improving a lot lately as tests have been added to the plugins and PRs are being reviewed and merged way faster than before. Please reconsider your decision and give the team some time to work through the backlog. If you wan't I can take this and open a PR with those changes. Please note that I am not part of the team and am also just trying to help.

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…all (flutter#1868)

* Solves the error `No implementation found for method CloudFunctions#call` introduced in the `0.4.1+7` release
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants