-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[video_player] updated ExoPlayer Android to version 2.10.5 #1868
[video_player] updated ExoPlayer Android to version 2.10.5 #1868
Conversation
- updated changelog and pubspec
|
Thanks for the contribution! I'm following the initial PR review policy, this PR isn't trivial to review so I'm labeling it with "backlog" and we will prioritize according to the issue's priority. related issue: flutter/flutter#36375 |
|
@cyanglaz What tests do we need? I can give it a try if we have a sample in the plugins repository. |
|
HI @BugsBunnyBR could you please update the PR to include ExoPlayer 2.10.5 ? |
I will do it latter today. |
|
Thank you for your contribution! Unfortunately the structure of the plugin has changed lately to support implementations on more platforms. Mainly the plugin was moved to a new subdirectory and now uses a common platform interface. Adapting your PR to the new structure should be straight forward. If you have questions please ask! I guess the version could be bumped to 2.10.8. |
|
I am closing this pr as it has not been merged until this date even though I kept it updated upon the team request I am no longer doing this. |
|
@BugsBunnyBR I totally understand your frustration. Things are improving a lot lately as tests have been added to the plugins and PRs are being reviewed and merged way faster than before. Please reconsider your decision and give the team some time to work through the backlog. If you wan't I can take this and open a PR with those changes. Please note that I am not part of the team and am also just trying to help. |
…all (flutter#1868) * Solves the error `No implementation found for method CloudFunctions#call` introduced in the `0.4.1+7` release
Description
Updates ExoPlayer for Android
https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?