-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_ml_vision] Add support for cloud text recognizer #1847
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
collinjackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add an integration test for this feature? See text_recognizer for an example.
Also make sure to update pubspec.yaml and CHANGELOG for release.
Thanks!
I have tried to add the integration test for cloud text recognizer but the API need a API key (with payment enable). I don't really think it is possible to bypass it without mocking the response of the request. Also I notice that the image labeler also don't have the integration test for it. Please let me know what is the appropriate action to take. Here is the exception I got: From my personal project the library work. I updated |
Description
Add support for cloud text recognizer to firebase_ml_vision plugin.
Related Issues
No related issues.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?