Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@tatiesmars
Copy link
Contributor

@tatiesmars tatiesmars commented Jul 13, 2019

Description

Add support for cloud text recognizer to firebase_ml_vision plugin.

Related Issues

No related issues.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tatiesmars
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an integration test for this feature? See text_recognizer for an example.

https://github.com/flutter/plugins/blob/master/packages/firebase_ml_vision/example/test_driver/text_recognizer.dart

Also make sure to update pubspec.yaml and CHANGELOG for release.

Thanks!

@tatiesmars
Copy link
Contributor Author

tatiesmars commented Jul 16, 2019

Can you please add an integration test for this feature? See text_recognizer for an example.

https://github.com/flutter/plugins/blob/master/packages/firebase_ml_vision/example/test_driver/text_recognizer.dart

Also make sure to update pubspec.yaml and CHANGELOG for release.

Thanks!

I have tried to add the integration test for cloud text recognizer but the API need a API key (with payment enable). I don't really think it is possible to bypass it without mocking the response of the request.

Also I notice that the image labeler also don't have the integration test for it.

Please let me know what is the appropriate action to take.

Here is the exception I got:

I/flutter (10466):   PlatformException(textRecognizerError, 400 Bad Request
I/flutter (10466):   {
I/flutter (10466):     "code": 400,
I/flutter (10466):     "errors": [
I/flutter (10466):       {
I/flutter (10466):         "domain": "global",
I/flutter (10466):         "message": "API key not valid. Please pass a valid API key.",
I/flutter (10466):         "reason": "badRequest"
I/flutter (10466):       }
I/flutter (10466):     ],
I/flutter (10466):     "message": "API key not valid. Please pass a valid API key.",
I/flutter (10466):     "status": "INVALID_ARGUMENT"
I/flutter (10466):   }, null)

From my personal project the library work.


I updated pubspec.yaml and CHANGELOG.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants