Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

Description

We need to override hashCode if overriding ==, some of the classes are missing this override.

@cyanglaz cyanglaz requested a review from mklim as a code owner July 10, 2019 22:00
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: pubspec.yaml also needs to be updated.

@cyanglaz cyanglaz merged commit 53ff711 into flutter:master Jul 10, 2019
@cyanglaz cyanglaz deleted the iap_health branch July 10, 2019 23:57
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants