Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/google_sign_in/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## 4.0.3
## 4.0.4

* Update guava to `27.0.1-android`.
* Add correct @NonNull annotations to reduce compiler warnings.
* Revert changes in 4.0.3.

## 4.0.3

* Update guava to `27.0.1-android`.
* Add correct @NonNull annotations to reduce compiler warnings.

## 4.0.2

Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ android {

dependencies {
api 'com.google.android.gms:play-services-auth:16.0.1'
implementation 'com.google.guava:guava:27.0.1-android'
implementation 'com.google.guava:guava:20.0'
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import android.accounts.Account;
import android.app.Activity;
import android.content.Intent;
import android.text.TextUtils;
import androidx.annotation.NonNull;
import com.google.android.gms.auth.GoogleAuthUtil;
import com.google.android.gms.auth.UserRecoverableAuthException;
import com.google.android.gms.auth.api.signin.GoogleSignIn;
Expand All @@ -22,6 +20,8 @@
import com.google.android.gms.tasks.OnCompleteListener;
import com.google.android.gms.tasks.RuntimeExecutionException;
import com.google.android.gms.tasks.Task;
import com.google.common.base.Joiner;
import com.google.common.base.Strings;
import io.flutter.plugin.common.MethodCall;
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
Expand Down Expand Up @@ -107,7 +107,7 @@ public void onMethodCall(MethodCall call, Result result) {

/**
* A delegate interface that exposes all of the sign-in functionality for other plugins to use.
* The below {@link Delegate} implementation should be used by any clients unless they need to
* The below {@link #Delegate} implementation should be used by any clients unless they need to
* override some of these functions, such as for testing.
*/
public interface IDelegate {
Expand Down Expand Up @@ -243,7 +243,7 @@ public void init(
for (String scope : requestedScopes) {
optionsBuilder.requestScopes(new Scope(scope));
}
if (!TextUtils.isEmpty(hostedDomain)) {
if (!Strings.isNullOrEmpty(hostedDomain)) {
optionsBuilder.setHostedDomain(hostedDomain);
}

Expand All @@ -270,7 +270,7 @@ public void signInSilently(Result result) {
task.addOnCompleteListener(
new OnCompleteListener<GoogleSignInAccount>() {
@Override
public void onComplete(@NonNull Task<GoogleSignInAccount> task) {
public void onComplete(Task<GoogleSignInAccount> task) {
onSignInResult(task);
}
});
Expand Down Expand Up @@ -305,7 +305,7 @@ public void signOut(Result result) {
.addOnCompleteListener(
new OnCompleteListener<Void>() {
@Override
public void onComplete(@NonNull Task<Void> task) {
public void onComplete(Task<Void> task) {
if (task.isSuccessful()) {
finishWithSuccess(null);
} else {
Expand All @@ -325,7 +325,7 @@ public void disconnect(Result result) {
.addOnCompleteListener(
new OnCompleteListener<Void>() {
@Override
public void onComplete(@NonNull Task<Void> task) {
public void onComplete(Task<Void> task) {
if (task.isSuccessful()) {
finishWithSuccess(null);
} else {
Expand Down Expand Up @@ -448,7 +448,7 @@ public void getTokens(
@Override
public String call() throws Exception {
Account account = new Account(email, "com.google");
String scopesStr = "oauth2:" + TextUtils.join(" ", requestedScopes);
String scopesStr = "oauth2:" + Joiner.on(' ').join(requestedScopes);
return GoogleAuthUtil.getToken(registrar.context(), account, scopesStr);
}
};
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
for signing in with a Google account on Android and iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in
version: 4.0.3
version: 4.0.4

flutter:
plugin:
Expand Down