This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] iOS: Support unsupported UserInfo value types on NSError. #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
approved these changes
Jul 9, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
Thank you for the contribution! This is great!
| @@ -1,3 +1,7 @@ | |||
| ## 0.2.0+4 | |||
|
|
|||
| * Fix a UserInfo types on NSError. | |||
Contributor
There was a problem hiding this comment.
Nits:
Suggested change
| * Fix a UserInfo types on NSError. | |
| * iOS: Support unsupported UserInfo value types on NSError. |
Contributor
Author
cyanglaz
added
the
submit queue
Contributor
|
@YukiOya There seems to be some conflicts. Could you please rebase? |
YukiOya
changed the title
YukiOya
changed the title
|
great |
This was referenced Jul 10, 2019
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a converting process because UserInfo of NSError contains a value of a type not supported by flutter like
NSErrorandNSURL.https://flutter.dev/docs/development/platform-integration/platform-channels#platform-channel-data-types-support-and-codecs
Related Issues
flutter/flutter#35554
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?