This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_database] Move firebase_database transaction calls to UI thread on Android #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
collinjackson
changed the title
cyanglaz
approved these changes
Jul 8, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM after removing the conflict mark
Co-Authored-By: Chris Yang <[email protected]>
|
@collinjackson Just wanted to drop in and say thank you. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
…read on Android (flutter#1812) * Move calls to UI thread * Update packages/firebase_database/CHANGELOG.md Co-Authored-By: Chris Yang <[email protected]>
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…read on Android (flutter#1812) * Move calls to UI thread * Update packages/firebase_database/CHANGELOG.md Co-Authored-By: Chris Yang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move firebase_database transaction-related calls to UI thread. This resolves "Error (Methods marked with @UiThread must be executed on the main thread)" in recent versions of Flutter.
I've verified that this fixes the existing transactions integration test.
Related Issues
Fixes flutter/flutter#33562
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?