[path_provider] Update to use getExternalFilesDir

packages/path_provider/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.1.2
+
+* `getExternalStorageDirectory` now uses `getExternalFilesDir` on Android.
+
 ## 1.1.1
 
 * Cast error codes as longs in iOS error strings to ensure compatibility

packages/path_provider/android/src/main/java/io/flutter/plugins/pathprovider/PathProviderPlugin.java

@@ -4,7 +4,6 @@
 
 package io.flutter.plugins.pathprovider;
 
-import android.os.Environment;
 import io.flutter.plugin.common.MethodCall;
 import io.flutter.plugin.common.MethodChannel;
 import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
@@ -52,6 +51,6 @@ private String getPathProviderApplicationDocumentsDirectory() {
   }
 
   private String getPathProviderStorageDirectory() {
-    return Environment.getExternalStorageDirectory().getAbsolutePath();
+    return mRegistrar.context().getExternalFilesDir(null).getAbsolutePath();
   }
 }

packages/path_provider/example/test_driver/path_provider.dart

@@ -56,9 +56,12 @@ void main() {
       expect(result, throwsA(isInstanceOf<UnsupportedError>()));
     } else if (Platform.isAndroid) {
       final Directory result = await getExternalStorageDirectory();
-      // This directory is not accessible in Android emulators.
-      // However, it should at least have a fake path returned.
-      expect(result.path.length, isNonZero);
+      final String uuid = Uuid().v1();
+      final File file = File('${result.path}/$uuid.txt');
+      file.writeAsStringSync('Hello world!');
+      expect(file.readAsStringSync(), 'Hello world!');
+      expect(result.listSync(), isNotEmpty);
+      file.deleteSync();
     }
   });
 }

packages/path_provider/lib/path_provider.dart

@@ -76,7 +76,7 @@ Future<Directory> getApplicationDocumentsDirectory() async {
 /// On iOS, this function throws an [UnsupportedError] as it is not possible
 /// to access outside the app's sandbox.
 ///
-/// On Android this uses the `getExternalStorageDirectory` API.
+/// On Android this uses the `getExternalFilesDir(null)`.
 Future<Directory> getExternalStorageDirectory() async {
   if (Platform.isIOS)
     throw UnsupportedError("Functionality not available on iOS");

packages/path_provider/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for getting commonly used locations on the Android &
   iOS file systems, such as the temp and app data directories.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider
-version: 1.1.1
+version: 1.1.2
 
 flutter:
   plugin: