Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@spockfish
Copy link
Contributor

Description

In the 'prepareKeys()' method the keys needed to be added to a map that is being returned. In the method there's an iteration over the keys, but the keys are not added to the resulting map. This leads to the issue that custom keys are not being reported to Crashlytics. This PR fixes that.

Related Issues

Fixes flutter/flutter#32873

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson
Copy link
Contributor

Thanks so much for your contribution. I've added tests to your PR. In the future please try to include tests -- it really saves us a lot of time reviewing.

@collinjackson collinjackson merged commit 15558f2 into flutter:master Jul 8, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
…eturned map (flutter#1799)

* make sure the keys are actually added to the returned map

* Add testing, removed a print
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…eturned map (flutter#1799)

* make sure the keys are actually added to the returned map

* Add testing, removed a print
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Crashlytics plugin - keys don't work

3 participants