-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher]: add option to enable DOM storage in android webview #1782
Conversation
|
Hi @mklim, could you take a look on this PR? Thanks~ |
mklim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The approach and tests look good. Just one nit on the demo in the sample app.
| }), | ||
| child: const Text('Launch in app(JavaScript ON)'), | ||
| ), | ||
| RaisedButton( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This extra item is now causing the bottom to overflow in my testing. We should probably nest these all in a ListView now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I've done this, please take a look, thanks~
mklim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Great to see the PR is merged! |
|
Thanks! I plan on publishing this once our CI is green again. It doesn't look like the issue is this change, but waiting on it to officially go green again just to be safe. |
|
Yes, safe is always the first priority, thanks for your time in advance 🍻 |
|
@nekolab this is published! https://pub.dev/packages/url_launcher/versions/5.0.5 |

Description
As we all known, like JavaScript, android webview is disable DOM storage by default.
To enable it, this PR provides an option to enable DOM storage in android webview.
Related Issues
Not created
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?