Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@nekolab
Copy link
Contributor

@nekolab nekolab commented Jun 30, 2019

Description

As we all known, like JavaScript, android webview is disable DOM storage by default.
To enable it, this PR provides an option to enable DOM storage in android webview.

Related Issues

Not created

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@nekolab
Copy link
Contributor Author

nekolab commented Jul 2, 2019

Hi @mklim, could you take a look on this PR? Thanks~

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The approach and tests look good. Just one nit on the demo in the sample app.

}),
child: const Text('Launch in app(JavaScript ON)'),
),
RaisedButton(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This extra item is now causing the bottom to overflow in my testing. We should probably nest these all in a ListView now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've done this, please take a look, thanks~

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the contribution!

@mklim mklim self-assigned this Jul 10, 2019
@mklim mklim merged commit e919c02 into flutter:master Jul 10, 2019
@nekolab
Copy link
Contributor Author

nekolab commented Jul 10, 2019

Great to see the PR is merged!
And may I know when will the new version publish to dart pub?

@mklim
Copy link
Contributor

mklim commented Jul 10, 2019

Thanks! I plan on publishing this once our CI is green again. It doesn't look like the issue is this change, but waiting on it to officially go green again just to be safe.

@nekolab
Copy link
Contributor Author

nekolab commented Jul 10, 2019

Yes, safe is always the first priority, thanks for your time in advance 🍻

@mklim
Copy link
Contributor

mklim commented Jul 10, 2019

@nekolab this is published! https://pub.dev/packages/url_launcher/versions/5.0.5

mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants