This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_firestore] Transactions improvements #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
* Add a test for rapidly updating in quick succession * Teach Transaction how to await automatically
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Add a test for rapidly updating in quick succession * Teach Transaction how to await automatically
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…utter#1780) * add 'app' to signature of FirebaseAuthPlatform.confirmPasswordReset * Update packages/firebase_auth/firebase_auth_platform_interface/CHANGELOG.md Co-authored-by: Collin Jackson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to transactions
Transactionmethods no longer cause errors when you fail toawait. Fixes Cloud Firestore Do transaction failed. Reply already submitted flutter#34747FieldValue.increment. We also seen reports of FieldValue.increment causing crashes (Cloud Firestore FieldValue.increment in quick succession crashes app on Android flutter#35269) so I'm checking in a test for this. Test is passing for me, so I'm curious what devices it fails on.