This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Add a PR triage policy to the contributing guide. #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mklim
reviewed
Jun 28, 2019
CONTRIBUTING.md
Outdated
|
|
||
| ### The review process | ||
|
|
||
| Reviewing PRs often requires a non trivial amount of time, as our goal is to use maintainers' time in the most impactful way, we perform prioritization on issues and not on PRs. Issues pertaining to this repository are managed in the [flutter/flutter issue tracker and are labeled with "plugin"](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3Aplugin+sort%3Areactions-%2B1-desc). Non trivial PRs should have an associated issue that will be used for prioritization. See the [prioritization section](https://github.com/flutter/flutter/wiki/Issue-hygiene#prioritization) in the Flutter wiki to understand how issues are prioritized. |
Contributor
There was a problem hiding this comment.
nit: the "as our goal" bit doesn't quite follow. I'm not sure what the named prescriptivist rules are for this, but it's hard to parse and reads almost like a run on. I'd rephrase to break these up into distinct sentences. Something like below (only a suggestion):
Reviewing PRs often requires a non trivial amount of time. We prioritize issues, not PRs, so that we use our maintainers' time in the most impactful way.
Contributor
|
Ideally all of this would go to the wiki, as we have done for the engine and framework contributor docs. (Doesn't have to block this PR, though.) |
Contributor
Contributor
Author
|
Filed flutter/flutter#35747 to move all contents from CONTRIUBTING.md to the wiki. Landing this for now. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.