This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[all_plugins] Compile all plugins together #1776
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
802d13e
Compile all plugins together
bparrishMines 1647752
Do pub get after generating pubspec
bparrishMines fd2f0bb
Add pod install?
bparrishMines c16d19d
Add xcconfigs
bparrishMines 6e76e45
remove no codesign param
bparrishMines 9f39ab0
build for simulator
bparrishMines d166a68
Print
bparrishMines bcb090a
Threading bro?
bparrishMines 9bbeb7e
Remove pod file and exclude firebase_core & firebase_ml_vision
bparrishMines 3d073e9
remove files from pr
bparrishMines 27c0abc
Remove Generated pubspec
bparrishMines 7572cd6
Add pubspec to gitignore
bparrishMines d525ec7
Merge branch 'master' of github.com:flutter/plugins into add_em_yo
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,8 @@ | |
| .dart_tool/ | ||
| pubspec.lock | ||
|
|
||
| examples/all_plugins/pubspec.yaml | ||
|
|
||
| Podfile | ||
| Podfile.lock | ||
| Pods/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| android.enableJetifier=true | ||
| android.useAndroidX=true | ||
| org.gradle.jvmargs=-Xmx1536M | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,72 +1 @@ | ||
| name: all_plugins | ||
| description: Flutter app containing all 1st party plugins. | ||
|
|
||
| # The following defines the version and build number for your application. | ||
| # A version number is three numbers separated by dots, like 1.2.43 | ||
| # followed by an optional build number separated by a +. | ||
| # Both the version and the builder number may be overridden in flutter | ||
| # build by specifying --build-name and --build-number, respectively. | ||
| # In Android, build-name is used as versionName while build-number used as versionCode. | ||
| # Read more about Android versioning at https://developer.android.com/studio/publish/versioning | ||
| # In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion. | ||
| # Read more about iOS versioning at | ||
| # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html | ||
| version: 1.0.0+1 | ||
|
|
||
| environment: | ||
| sdk: ">=2.1.0 <3.0.0" | ||
|
|
||
| dependencies: | ||
| flutter: | ||
| sdk: flutter | ||
|
|
||
| # The following adds the Cupertino Icons font to your application. | ||
| # Use with the CupertinoIcons class for iOS style icons. | ||
| cupertino_icons: ^0.1.2 | ||
|
|
||
| dev_dependencies: | ||
| flutter_test: | ||
| sdk: flutter | ||
|
|
||
|
|
||
| # For information on the generic Dart part of this file, see the | ||
| # following page: https://dart.dev/tools/pub/pubspec | ||
|
|
||
| # The following section is specific to Flutter. | ||
| flutter: | ||
|
|
||
| # The following line ensures that the Material Icons font is | ||
| # included with your application, so that you can use the icons in | ||
| # the material Icons class. | ||
| uses-material-design: true | ||
|
|
||
| # To add assets to your application, add an assets section, like this: | ||
| # assets: | ||
| # - images/a_dot_burr.jpeg | ||
| # - images/a_dot_ham.jpeg | ||
|
|
||
| # An image asset can refer to one or more resolution-specific "variants", see | ||
| # https://flutter.dev/assets-and-images/#resolution-aware. | ||
|
|
||
| # For details regarding adding assets from package dependencies, see | ||
| # https://flutter.dev/assets-and-images/#from-packages | ||
|
|
||
| # To add custom fonts to your application, add a fonts section here, | ||
| # in this "flutter" section. Each entry in this list should have a | ||
| # "family" key with the font family name, and a "fonts" key with a | ||
| # list giving the asset and other descriptors for the font. For | ||
| # example: | ||
| # fonts: | ||
| # - family: Schyler | ||
| # fonts: | ||
| # - asset: fonts/Schyler-Regular.ttf | ||
| # - asset: fonts/Schyler-Italic.ttf | ||
| # style: italic | ||
| # - family: Trajan Pro | ||
| # fonts: | ||
| # - asset: fonts/TrajanPro.ttf | ||
| # - asset: fonts/TrajanPro_Bold.ttf | ||
| # weight: 700 | ||
| # | ||
| # For details regarding fonts from package dependencies, | ||
| # see https://flutter.dev/custom-fonts/#from-packages | ||
| ### Generated file. Run `pub global run flutter_plugin_tools gen-pubspec`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,14 +4,15 @@ | |
| # sure all first party plugins can be compiled together. | ||
|
|
||
| # So that users can run this script from anywhere and it will work as expected. | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null && pwd)" | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" > /dev/null && pwd)" | ||
| REPO_DIR="$(dirname "$SCRIPT_DIR")" | ||
|
|
||
| source "$SCRIPT_DIR/common.sh" | ||
| check_changed_packages > /dev/null | ||
|
|
||
| cd $REPO_DIR/examples/all_plugins | ||
| flutter clean > /dev/null | ||
| (cd "$REPO_DIR" && pub global run flutter_plugin_tools gen-pubspec --exclude firebase_core,firebase_ml_vision) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exclude Exclude
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sgtm. note that we'll be moving these plugins out of this repo soon. |
||
|
|
||
| function error() { | ||
| echo "$@" 1>&2 | ||
|
|
@@ -20,7 +21,7 @@ function error() { | |
| failures=0 | ||
|
|
||
| for version in "debug" "release"; do | ||
| (flutter build $@ --$version) > /dev/null | ||
| (flutter build $@ --$version > /dev/null) | ||
|
|
||
| if [ $? -eq 0 ]; then | ||
| echo "Successfully built $version all_plugins app." | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required because camera plugin is 21+