This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Adds support for displaying the traffic layer #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-burton
force-pushed
the
google-maps-traffic
branch
from
4db64de to
09ab62c
Compare
Contributor
Author
|
@iskakaushik @amirh would really appreciate your review if you get a chance. |
josh-burton
force-pushed
the
google-maps-traffic
branch
from
09ab62c to
f638b0b
Compare
josh-burton
force-pushed
the
google-maps-traffic
branch
from
f638b0b to
67b538c
Compare
Contributor
|
Can you add some tests which get |
josh-burton
force-pushed
the
google-maps-traffic
branch
from
67b538c to
8c67b92
Compare
Contributor
Author
|
@iskakaushik done :) |
josh-burton
force-pushed
the
google-maps-traffic
branch
2 times, most recently
from
33eb17c to
b57150f
Compare
Contributor
Author
|
@iskakaushik do you require any other changes for this to merge? |
josh-burton
force-pushed
the
google-maps-traffic
branch
from
b57150f to
608d42f
Compare
|
@iskakaushik I have been waiting for this merge to complete, my production app needs the feature this branch provides. Thanks in advance. |
Contributor
|
Thanks for this contribution! |
|
@athornz please fix trafficEnabled on Android |
Contributor
Author
|
@monnguyen2512 should be an easy fix - maybe give it a go yourself? |
|
@athornz ok, I fixed it |
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…lutter#1767) * [google_maps_flutter] Adds support for displaying the traffic layer * [google_maps_flutter] Adds traffic layer tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a toggle for the Google Maps Traffic layer.
Related Issues
flutter/flutter#25334
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?