This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Fix camera memory leak on IOS #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to unregister the stream handler when disposing of the camera
Contributor
Author
|
Any news on when this might be incorporated? We have an app that will be posted in the app store very soon and it would be nice to have this fix included since it does indeed cause a crash on some IOS devices if the camera is opened and closed multiple times. |
mklim
reviewed
Jul 8, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
Thanks for your patience and the contribution! I have some feedback on the approach.
Per @mklim the release of the event channel was moved to onCancel vs. dispose.
mklim
approved these changes
Jul 22, 2019
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM with one nit. Thanks again!
|
Just tested the camera plugin version 0.5.2+2 on an iphone 5S running OS 12.3 and after every time the camera opens and closes the memory usage keeps on increasing quickly (took about 10 times for the camera to open and close to terminate the app) |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Needed to unregister the stream handler when disposing of the camera Per the flutter documentation, the stream handler should be unregistered using setStreamHandler with nil. https://api.flutter.dev/objcdoc/Classes/FlutterEventChannel.html#/c:objc(cs)FlutterEventChannel(im)setStreamHandler:
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Needed to unregister the stream handler when disposing of the camera Per the flutter documentation, the stream handler should be unregistered using setStreamHandler with nil. https://api.flutter.dev/objcdoc/Classes/FlutterEventChannel.html#/c:objc(cs)FlutterEventChannel(im)setStreamHandler:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to unregister the stream handler when disposing of the camera
Description
Per the flutter documentation, the stream handler should be unregistered using setStreamHandler with nil.
https://api.flutter.dev/objcdoc/Classes/FlutterEventChannel.html#/c:objc(cs)FlutterEventChannel(im)setStreamHandler:
Related Issues
Possibly fixes:
flutter/flutter#29586
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?