Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Allow BitmapDescriptor scaling override #1737

Merged
iskakaushik merged 5 commits into from
Jun 21, 2019
Merged

[google_maps_flutter] Allow BitmapDescriptor scaling override #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9597ec
Allow BitmapDescriptor scaling override
duzenko Jun 12, 2019
74e4333
Merge commit '1e01c9e12d564642735e1a7308a21083b9769b11' into maps-sca…
duzenko Jun 13, 2019
c7beecf
Merge remote-tracking branch 'upstream/master' into maps-scaling-bitmap
duzenko Jun 20, 2019
9cf14ff
Updated the pubspec.yml and changelog files
duzenko Jun 20, 2019
7375645
Merge commit '400bc414afb1e3088ff3c59b841149d1fba1a8e1' into maps-sca…
duzenko Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.19

* Allow BitmapDescriptor scaling override

## 0.5.18

* Fixed build issue on iOS.
Expand Down
7 changes: 7 additions & 0 deletions packages/google_maps_flutter/lib/src/bitmap.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ class BitmapDescriptor {
AssetBundle bundle,
String package,
}) async {
if (configuration.devicePixelRatio != null) {
return BitmapDescriptor._(<dynamic>[
'fromAssetImage',
assetName,
configuration.devicePixelRatio,
]);
}
Copy link
Contributor

@iskakaushik iskakaushik Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 76 can be configuration.devicePixelRatio ?? assetBundleImageKey.scale

This comment has been minimized.

Sign in to view

Copy link
Contributor

@iskakaushik iskakaushik Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

final AssetImage assetImage =
AssetImage(assetName, package: package, bundle: bundle);
final AssetBundleImageKey assetBundleImageKey =
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
author: Flutter Team <[email protected]>
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter
version: 0.5.18
version: 0.5.19

dependencies:
flutter:
Expand Down