-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_messaging]: add additional documentation for the data in notifications #1728
[firebase_messaging]: add additional documentation for the data in notifications #1728
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
i am the only author of the change. Maybe the problem is that i pushed it using another computer than normal and therefore commited strange author informations.. |
|
Thanks for the contribution. I'd like to consider making some breaking changes to allow more re-use of code across platforms, but I maybe for now documenting the current behavior is better than having it be confusing. Can you please fix the analyzer failures? |
|
@collinjackson done |
Description
In the documentation of the firebase_messaging plugin could have a more detailed section about accessing the data send alongside the notification. It would help not to waste time debugging and finding the errors if the documentation would explain it a bit better..
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?