Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ehhc
Copy link
Contributor

@ehhc ehhc commented Jun 12, 2019

Description

In the documentation of the firebase_messaging plugin could have a more detailed section about accessing the data send alongside the notification. It would help not to waste time debugging and finding the errors if the documentation would explain it a bit better..

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ehhc
Copy link
Contributor Author

ehhc commented Jun 12, 2019

I signed it!
:)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@ehhc
Copy link
Contributor Author

ehhc commented Jun 12, 2019

i am the only author of the change. Maybe the problem is that i pushed it using another computer than normal and therefore commited strange author informations..

@collinjackson collinjackson added the submit queue The Flutter team is in the process of landing this PR. label Jul 16, 2019
@collinjackson
Copy link
Contributor

Thanks for the contribution.

I'd like to consider making some breaking changes to allow more re-use of code across platforms, but I maybe for now documenting the current behavior is better than having it be confusing.

Can you please fix the analyzer failures?

@ehhc
Copy link
Contributor Author

ehhc commented Jul 17, 2019

@collinjackson done

@collinjackson collinjackson merged commit da1a3eb into flutter:master Jul 17, 2019
@ehhc ehhc deleted the additional_documentation_firebase_messagin branch July 18, 2019 06:20
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: no flutterfire submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants