-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[firebase_auth] Expose AdditionalUserInfo to Firebase User #1614
Conversation
|
Hey guys - I see some checks failed here that look pretty easy to solve. Really hoping this makes it in, exposing the new user flag is quite helpful for me. |
|
Thanks for this PR. The integration test I added is currently failing on iOS because there's no iOS implementation. Would you be open to adding one? |
|
Hi, |
|
Is it possible for you to add this implementation? @collinjackson |
|
I'm looking at this change more carefully and I think a different approach is needed. The Unfortunately changing the return value of the sign-in methods is a breaking change that will affect every developer using this plugin. I'll try to get some feedback on naming internally so we don't have to do this more than once. FYI @Ehesp |
|
I'd be willing to work on the iOS implementation once the naming issue has been resolved and breaking changes are made clear. 👋🏻 |
|
Hey - We took the |
|
I got some feedback internally and we're going to call the result class I went ahead and implemented the changes we've discussed in #1911. @jeroen-meijer I appreciate your generous offer to help; if you could take a quick look at #1911 and let me know if you have any feedback I'd appreciate it. |
Description
This PR exposes the user's additional information. Useful for retrieving whether the user is new to your app, their IDP-specific user data and username (if the provider is Github or Twitter) .
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?