[firebase_ml_vision] adds facial contours #1599

p30arena · 2019-05-14T08:40:03Z

Description

modified .gitignore to ommit some vscode related directories.
added contours to both android and iOS.
I'm not sure about sanity of the iOS part.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

modified .gitignore to ommit some vscode related directories. added contours to both android and iOS. I'm not sure about sanity of the iOS part.

p30arena · 2019-05-14T09:37:04Z

@bparrishMines

These files are not formatted correctly (see diff above):
firebase_ml_vision/android/src/main/java/io/flutter/plugins/firebasemlvision/FaceDetector.java
firebase_ml_vision/ios/Classes/FaceDetector.m

D:\GitHub\p30arena\plugins> pub global run flutter_plugin_tools format
Downloading Google Java Format...
Formatting all .dart files...
CreateProcessW failed 2
Unhandled exception:
ProcessException: The system cannot find the file specified.

formatted using vscode

p30arena · 2019-05-14T10:18:31Z

I had to run the formatters manually

clang-format -i --style=google  .\FaceDetector.m
java -jar path\to\google-java-format-1.3-all-deps.jar --replace .\FaceDetector.java

p30arena · 2019-05-14T10:31:42Z

contours should never be null
but I'm getting this error (maybe on iOS side?)

00:07 +18 -1: /tmp/cirrus-ci-build/packages/firebase_ml_vision/test/firebase_ml_vision_test.dart: FirebaseVision FaceDetector processImage [E]                                                         
  NoSuchMethodError: The method '[]' was called on null.
  Receiver: null
  Tried calling: []("allPoints")
  dart:core                                                 Object.noSuchMethod
  package:firebase_ml_vision/src/face_detector.dart 167:53  new Face._.<fn>
  dart:collection                                           new LinkedHashMap.fromIterables
  package:firebase_ml_vision/src/face_detector.dart 164:19  new Face._
  package:firebase_ml_vision/src/face_detector.dart 85:22   FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _AsyncAwaitCompleter.completeError
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _asyncThenWrapperHelper
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  firebase_ml_vision_test.dart 545:49                       main.<fn>.<fn>.<fn>

p30arena · 2019-05-14T12:28:13Z

I observed that this doubles (13MB to 30MB) the output size of the APK.
Was this the reason that you haven't had implemented contours in this plugin?

bparrishMines · 2019-05-15T00:21:44Z

Hi @p30arena

We haven't added this feature yet because we are currently focusing on integration testing. Once we implement those, it will be easier for us to add additional features to the plugin.

Also, to avoid automatically increasing the size of the APK, we would not include the line api 'com.google.firebase:firebase-ml-vision-face-model:17.0.2' in the build.gradle file. ML Kit models are quite large, so we allow the developer to choose what models to add. For example, if you want to use the ImageLabeler we instruct them to add the dependency themselves. README

Edit: Same for the line s.dependency 'Firebase/MLVisionFaceModel' in the podspec

p30arena · 2019-07-02T18:33:06Z

@bparrishMines
Hi there!
Isn't this going to be merged any time soon?

bparrishMines

Thanks for the contribution!

Sorry for the delay. Everything looks good. I added a single comment.

Can you handle the merge conflicts, update the pubspec.yaml, and update the CHANGELOG? If not, I can also do these for you.

packages/firebase_ml_vision/README.md

bparrishMines · 2019-07-18T19:07:14Z

contours should never be null
but I'm getting this error (maybe on iOS side?)

00:07 +18 -1: /tmp/cirrus-ci-build/packages/firebase_ml_vision/test/firebase_ml_vision_test.dart: FirebaseVision FaceDetector processImage [E]                                                         
  NoSuchMethodError: The method '[]' was called on null.
  Receiver: null
  Tried calling: []("allPoints")
  dart:core                                                 Object.noSuchMethod
  package:firebase_ml_vision/src/face_detector.dart 167:53  new Face._.<fn>
  dart:collection                                           new LinkedHashMap.fromIterables
  package:firebase_ml_vision/src/face_detector.dart 164:19  new Face._
  package:firebase_ml_vision/src/face_detector.dart 85:22   FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _AsyncAwaitCompleter.completeError
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _asyncThenWrapperHelper
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  firebase_ml_vision_test.dart 545:49                       main.<fn>.<fn>.<fn>

Are you still running into this error? Could it be from not including the dependency in the app. I'm not sure if you are using the example app or another.

p30arena · 2019-07-19T02:41:34Z

Thanks for the contribution!

Sorry for the delay. Everything looks good. I added a single comment.

Can you handle the merge conflicts, update the pubspec.yaml, and update the CHANGELOG? If not, I can also do these for you.

I merged the conflicts,
but, please update the pubspec.yaml and CHANGELOG

Thanks

p30arena · 2019-07-19T02:42:17Z

contours should never be null
but I'm getting this error (maybe on iOS side?)

00:07 +18 -1: /tmp/cirrus-ci-build/packages/firebase_ml_vision/test/firebase_ml_vision_test.dart: FirebaseVision FaceDetector processImage [E]                                                         
  NoSuchMethodError: The method '[]' was called on null.
  Receiver: null
  Tried calling: []("allPoints")
  dart:core                                                 Object.noSuchMethod
  package:firebase_ml_vision/src/face_detector.dart 167:53  new Face._.<fn>
  dart:collection                                           new LinkedHashMap.fromIterables
  package:firebase_ml_vision/src/face_detector.dart 164:19  new Face._
  package:firebase_ml_vision/src/face_detector.dart 85:22   FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _AsyncAwaitCompleter.completeError
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  ===== asynchronous gap ===========================
  dart:async                                                _asyncThenWrapperHelper
  package:firebase_ml_vision/src/face_detector.dart         FaceDetector.processImage
  firebase_ml_vision_test.dart 545:49                       main.<fn>.<fn>.<fn>

Are you still running into this error? Could it be from not including the dependency in the app. I'm not sure if you are using the example app or another.

This error is resolved

bparrishMines

LGTM

I updated the version and added unit and integration tests.

adds contours

46e7cdb

modified .gitignore to ommit some vscode related directories. added contours to both android and iOS. I'm not sure about sanity of the iOS part.

googlebot added the cla: yes label May 14, 2019

p30arena added 2 commits May 14, 2019 14:11

formatted FaceDetector.java

66060e1

formatted using vscode

manual formatting

99e64a6

p30arena added 3 commits May 14, 2019 15:13

contours null

a972bad

contours null

af88d5b

[test] enableContours: false

f5807f2

p30arena changed the title ~~[firebase_ml_vision] adds contours~~ [firebase_ml_vision] adds facial contours May 14, 2019

bparrishMines added feature flutterfire labels May 15, 2019

updated dependencies

1301f7b

p30arena requested a review from bparrishMines as a code owner May 15, 2019 09:35

syntax

6b020db

bparrishMines reviewed Jul 18, 2019

View reviewed changes

packages/firebase_ml_vision/README.md Outdated Show resolved Hide resolved

bparrishMines added the in review label Jul 18, 2019

p30arena added 2 commits July 19, 2019 07:07

Merge branch 'master' into master

84a9141

unnecessary label

41c7907

bparrishMines added 3 commits July 19, 2019 15:05

Update version

004749a

Add unit test

b71bb0b

Add integration tests

7573934

collinjackson assigned bparrishMines Jul 22, 2019

bparrishMines added 2 commits July 22, 2019 16:59

Merge branch 'master' of github.com:flutter/plugins into p30arena/master

4be94e2

Use a single face in test image

8d4e0e6

bparrishMines approved these changes Jul 23, 2019

View reviewed changes

bparrishMines merged commit ed53cab into flutter:master Jul 23, 2019

mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019

[firebase_ml_vision] adds facial contours (flutter#1599)

6a41c7a

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

[firebase_ml_vision] adds facial contours (flutter#1599)

1ef4d22

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020

Fix pubspec format (flutter#1599)

0d0c224

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[firebase_ml_vision] adds facial contours #1599

[firebase_ml_vision] adds facial contours #1599

Uh oh!

p30arena commented May 14, 2019 •

edited

Loading

Uh oh!

p30arena commented May 14, 2019 •

edited

Loading

Uh oh!

p30arena commented May 14, 2019 •

edited

Loading

Uh oh!

p30arena commented May 14, 2019 •

edited

Loading

Uh oh!

p30arena commented May 14, 2019 •

edited

Loading

Uh oh!

bparrishMines commented May 15, 2019 •

edited

Loading

Uh oh!

p30arena commented Jul 2, 2019

Uh oh!

bparrishMines left a comment

Uh oh!

Uh oh!

bparrishMines commented Jul 18, 2019

Uh oh!

p30arena commented Jul 19, 2019 •

edited

Loading

Uh oh!

p30arena commented Jul 19, 2019

Uh oh!

bparrishMines left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[firebase_ml_vision] adds facial contours #1599

[firebase_ml_vision] adds facial contours #1599

Uh oh!

Conversation

p30arena commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

p30arena commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p30arena commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p30arena commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p30arena commented May 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparrishMines commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p30arena commented Jul 2, 2019

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bparrishMines commented Jul 18, 2019

Uh oh!

p30arena commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p30arena commented Jul 19, 2019

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

p30arena commented May 14, 2019 •

edited

Loading

p30arena commented May 14, 2019 •

edited

Loading

p30arena commented May 14, 2019 •

edited

Loading

p30arena commented May 14, 2019 •

edited

Loading

p30arena commented May 14, 2019 •

edited

Loading

bparrishMines commented May 15, 2019 •

edited

Loading

p30arena commented Jul 19, 2019 •

edited

Loading