This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Fix race condition on disposing the VideoController. #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, thanks for your contribution. I don't think this addresses flutter/flutter#30238, could you please remove that from your related issues please. Could you also update the version number, thanks! |
…ontroller_dispose # Conflicts: # packages/video_player/CHANGELOG.md # packages/video_player/pubspec.yaml
Contributor
Author
|
@iskakaushik done. |
|
We made a commercial app with Flutter that has thousands of users which is using video controller plugin. It would be perfect if this PR was accepted. So we won't have to use our fork. Thanks for PR and also effort of Flutter team! |
…ontroller_dispose # Conflicts: # packages/video_player/CHANGELOG.md
13 tasks
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After, or while in process of, disposing the VideoController, the
bufferingUpdateis still being fired which causes theChangeNotifier._debugAssertNotDisposedto fail.I am adding the verification of the
_disposeflag before applying any change to thevaluevariable.Related Issues
flutter/flutter#25936
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?