This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[In_app_purchase] Expose nslocale and expose currencySymbol instead of currencyCode to match android #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2019 11:49
mklim
reviewed
Feb 5, 2019
|
|
||
| - (nullable NSDictionary *)toMap { | ||
| NSMutableDictionary *map = [[NSMutableDictionary alloc] init]; | ||
| if (@available(iOS 10.0, *)) { |
Contributor
There was a problem hiding this comment.
So do we not have access to this information on ios < 10?
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…Code to match android (flutter#1162)" This reverts commit e23b8e3.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
cyanglaz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make to code simple, NSLocale has not been fully exposed.
Expose the NSLocale inside the priceLocale layer to match the SKProduct composition; this makes future changes regarding priceLocale to be non-breaking changes.