Workaround to fix the camera positioning issue on the google map view #1157
Conversation
|
|
||
| - (void)mapView:(GMSMapView*)mapView didChangeCameraPosition:(GMSCameraPosition*)position { | ||
| if (!_cameraDidInitialSetup) { | ||
| // A temporary workaround for a bug that the camera is not properly positioned at |
There was a problem hiding this comment.
Note that we suspect that this is an issue with the iOS Google Maps SDK(which is still being investigated), and that we call moveCamera to the current position as a temporary workaround.
Also include a TODO to remove this once the Maps SDK issue is resolved(I'm ok with closing the current Github issue with this workaround, and filing a separate one for this TODO).
There was a problem hiding this comment.
I meant note it in the code comment 😄
There was a problem hiding this comment.
updated the comments, and also opened the issue ticket.
| @@ -1,3 +1,7 @@ | |||
| ## 0.2.0+1 | |||
|
|
|||
| * Fixed a bug which the camera is not positioned correctly at map initialization(temporary workaround). | |||
There was a problem hiding this comment.
nit: we can reference the github issue.
I would also mentioned that it's a work around, e.g "Fixed(worked around) a bug..."
There was a problem hiding this comment.
I did add the workaround in the end of the sentence. Did you mean to remove it and add Fixed(worked around)?
There was a problem hiding this comment.
ohh oops missed that, that looks good.
There was a problem hiding this comment.
still lets reference the github issue
…flutter#1157) A temporary workaround to fix the camera positioning issue mentioned in [flutter/flutter#24806](flutter/flutter#24806) A follow-up issue has been opened to track the 'real' fix.(flutter/flutter#27550)
…map view (flutter#1157)" This reverts commit e0a2b37.
…flutter#1157) A temporary workaround to fix the camera positioning issue mentioned in [flutter/flutter#24806](flutter/flutter#24806) A follow-up issue has been opened to track the 'real' fix.(flutter/flutter#27550)
…flutter#1157) A temporary workaround to fix the camera positioning issue mentioned in [flutter/flutter#24806](flutter/flutter#24806) A follow-up issue has been opened to track the 'real' fix.(flutter/flutter#27550)
3 participants
A temporary workaround to fix the camera positioning issue mentioned in flutter/flutter#24806