Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Feb 1, 2019

Changed NSNull check to type check to make the code cleaner.

@cyanglaz cyanglaz requested a review from amirh February 1, 2019 22:28
@cyanglaz cyanglaz changed the title Objc code refactoring and cleanups. Update NSNull check with directly checking the expected type. Feb 4, 2019
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit d9495c9 into flutter:master Feb 5, 2019
@cyanglaz cyanglaz deleted the webview_objc_refactor branch February 5, 2019 00:22
andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
karantanwar pushed a commit to karantanwar/plugins that referenced this pull request Feb 19, 2019
karantanwar pushed a commit to karantanwar/plugins that referenced this pull request Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants