This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Added support for persisting alarms across reboots #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated android_alarm_manager to fix issues with "background start not allowed" when attempting to start AlarmService while backgrounded. * Switched to using a combination of BroadcastReceiver and JobIntentService from using a Service (launching a Service from an alarm Intent causes the "Background start not allowed" on Android 8+) * Alarm events received before the AlarmService isolate is finished initializing are now queued and processed once the isolate is initialized. * Updated CHANGELOG.md and README.md with new setup steps. * Bumped version to 0.4.0. Fixes #26846.
Android doesn't automatically reschedule alarms after a reboot, so alarms set using this plugin would have to be scheduled manually after each reboot. With this change, alarms scheduled with the 'rescheduleOnReboot' flag set to true will be rescheduled at boot.
Contributor
Author
|
cc @Hixie |
Contributor
|
Thanks! I'll defer to someone more familiar with the plug-in architecture do a thorough review. |
zanderso
approved these changes
Feb 4, 2019
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Added support for persisting alarms across reboots. Android doesn't automatically reschedule alarms after a reboot, so alarms set using this plugin would have to be scheduled manually after each reboot. With this change, alarms scheduled with the 'rescheduleOnReboot' flag set to true will be rescheduled at boot.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
)" This reverts commit 07a6f52.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Added support for persisting alarms across reboots. Android doesn't automatically reschedule alarms after a reboot, so alarms set using this plugin would have to be scheduled manually after each reboot. With this change, alarms scheduled with the 'rescheduleOnReboot' flag set to true will be rescheduled at boot.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
Added support for persisting alarms across reboots. Android doesn't automatically reschedule alarms after a reboot, so alarms set using this plugin would have to be scheduled manually after each reboot. With this change, alarms scheduled with the 'rescheduleOnReboot' flag set to true will be rescheduled at boot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android doesn't automatically reschedule alarms after a reboot, so
alarms set using this plugin would have to be scheduled manually after
each reboot. With this change, alarms scheduled with the 'rescheduleOnReboot'
flag set to true will be rescheduled at boot.