This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Use string to save double for shared_preference(Android). #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehmetf
reviewed
Jan 29, 2019
...nces/android/src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java
Show resolved
Hide resolved
mehmetf
approved these changes
Jan 29, 2019
Contributor
mehmetf
left a comment
mehmetf
left a comment
There was a problem hiding this comment.
LGTM barring one comment.
bparrishMines
added
bugfix
submit queue
...nces/android/src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mehmetf |
Contributor
|
Could you please update CHANGELOG and the version in pubspec.yaml as well? |
Contributor
Author
Done |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…utter#1132)" This reverts commit f79fc52.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use string to save double for shared_preference instead of converting it to float.
This will fix: flutter/flutter#27222