This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Fixed a crash that would occur when called in quick succession on Android #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
suggested changes
Jan 31, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
Thank you for fixing this.
The fix looks good. Commented on some nit fix. Please rebase and resolve conflicts.
wouterhardeman
force-pushed
the
image-picker-patch
branch
from
4afacc5 to
2f155b6
Compare
cyanglaz
approved these changes
Jan 31, 2019
cyanglaz
suggested changes
Jan 31, 2019
...s/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
Outdated
Show resolved
Hide resolved
Contributor
|
The original post of the same issue can be found here flutter/flutter#19819 |
cyanglaz
approved these changes
Jan 31, 2019
Contributor
|
LGTM! |
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…ccession on Android (flutter#1093)
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…quick succession on Android (flutter#1093)" This reverts commit fa66e1a.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
…ccession on Android (flutter#1093)
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
…ccession on Android (flutter#1093)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#19819
When the
image_pickeris called before another call is finished it should return an error with theMethodResultobject that came with the last method call. But instead it uses theMethodResultobject from the first method call. When finishing up the first method call, thependingResult(MethodResultobject of the first call) property will already be set to null.