Update CODEOWNERS #9692
Merged
Update CODEOWNERS #9692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set myself as the CODEOWNER of Linux and Windows plugins, as I currently have the most experience with them.
Collaborator
Author
|
@robert-ancell Are there Canonical folks who should be listed for the Linux plugins? These would be people who would be auto-assigned code reviews for changes, and would be the primary contact point for any significant changes. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CODEOWNERS file to assign ownership of the Linux and Windows plugins to a new owner. The change is straightforward and correct. I've added a couple of suggestions to improve the alignment within the file for better long-term readability and maintainability.
On a process note, the repository's style guide (lines 21-23) requires that PR descriptions include the Pre-Review Checklist. Please consider adding it to this PR's description to align with the project's contribution guidelines.
Collaborator
Author
|
@chinmaygarde Are you the right person to list for vector graphics now, or do you have someone else I should list? |
Member
|
I don't think so. Perhaps @jtmcdole can find one? We only roughly eyeball the issues during engine triage but aren't super familiar with the codebase or its requirements. |
Member
I could find someone, but I need to find out what the priority is for this package. Are we KSLO or accepting new features. |
Member
|
Just add me for now and I can find others to work on it when there are breaking changes. |
jtmcdole
approved these changes
Jul 29, 2025
tarrinneal
approved these changes
Jul 29, 2025
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/9692, because - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
Contributor
You can auto-assign me if reviews are required. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 30, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 30, 2025
flutter/packages@ed235d1...d914120 2025-07-30 [email protected] Roll Flutter from 46b097a to c3279ca (18 revisions) (flutter/packages#9699) 2025-07-29 [email protected] [video_player] Move more Obj-C logic to Dart (flutter/packages#9685) 2025-07-29 [email protected] Update CODEOWNERS (flutter/packages#9692) 2025-07-29 [email protected] [video_player] Move more Java logic to Dart (flutter/packages#9672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Set myself as the CODEOWNER of Linux and Windows plugins, as I currently have the most experience with them. Other minor changes to owners to reflect current owners.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@ed235d1...d914120 2025-07-30 [email protected] Roll Flutter from 46b097a to c3279ca (18 revisions) (flutter/packages#9699) 2025-07-29 [email protected] [video_player] Move more Obj-C logic to Dart (flutter/packages#9685) 2025-07-29 [email protected] Update CODEOWNERS (flutter/packages#9692) 2025-07-29 [email protected] [video_player] Move more Java logic to Dart (flutter/packages#9672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@ed235d1...d914120 2025-07-30 [email protected] Roll Flutter from 46b097a to c3279ca (18 revisions) (flutter/packages#9699) 2025-07-29 [email protected] [video_player] Move more Obj-C logic to Dart (flutter/packages#9685) 2025-07-29 [email protected] Update CODEOWNERS (flutter/packages#9692) 2025-07-29 [email protected] [video_player] Move more Java logic to Dart (flutter/packages#9672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@ed235d1...d914120 2025-07-30 [email protected] Roll Flutter from 46b097a to c3279ca (18 revisions) (flutter/packages#9699) 2025-07-29 [email protected] [video_player] Move more Obj-C logic to Dart (flutter/packages#9685) 2025-07-29 [email protected] Update CODEOWNERS (flutter/packages#9692) 2025-07-29 [email protected] [video_player] Move more Java logic to Dart (flutter/packages#9672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merged
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@ed235d1...d914120 2025-07-30 [email protected] Roll Flutter from 46b097a to c3279ca (18 revisions) (flutter/packages#9699) 2025-07-29 [email protected] [video_player] Move more Obj-C logic to Dart (flutter/packages#9685) 2025-07-29 [email protected] Update CODEOWNERS (flutter/packages#9692) 2025-07-29 [email protected] [video_player] Move more Java logic to Dart (flutter/packages#9672) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set myself as the CODEOWNER of Linux and Windows plugins, as I currently have the most experience with them.
Other minor changes to owners to reflect current owners.