-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[pigeon] reorg generator files #8532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
48e3856
0a31afb
3904870
cd61ce7
78235eb
b9cdb8c
962cd89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
|
|
||
| import 'dart:io' show exit; | ||
|
|
||
| import 'package:pigeon/pigeon_cl.dart'; | ||
| import 'package:pigeon/src/pigeon_cl.dart'; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting, I guess
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was surprised it was allowed as well, since the pigeon_cl.dart file is used outside of lib and tests, should I move it back out of src?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope, I found a reference later on the page I had linked to, it's explicitly allowed:
And that's the preferred format for such an include:
|
||
|
|
||
| Future<void> main(List<String> args) async { | ||
| exit(await runCommandLine(args)); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.