Skip to content

[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 14 commits into from
Sep 6, 2024
Merged

[extension_google_sign_in_as_googleapis_auth][google_maps_flutter_ios] Manual roll with fixes to example and skipping some native tests #7571

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6339d87
update examples
bparrishMines Sep 3, 2024
8de6287
Merge branch 'main' of github.com:flutter/packages into update_examples
bparrishMines Sep 3, 2024
1f46aec
undo specific changes
bparrishMines Sep 3, 2024
9ecfc12
raise jvm limit
bparrishMines Sep 3, 2024
83ef738
manual roll
bparrishMines Sep 3, 2024
bb8d313
Merge branch 'main' of github.com:flutter/packages into update_examples
bparrishMines Sep 3, 2024
bc6bd3d
Merge branch 'main' into update_examples
gmackall Sep 3, 2024
6039ea8
Merge branch 'main' of github.com:flutter/packages into update_examples
bparrishMines Sep 4, 2024
4d0e113
try manual roll
bparrishMines Sep 4, 2024
a4fe594
Merge branch 'update_examples' of github.com:bparrishMines/packages i…
bparrishMines Sep 4, 2024
39d73c4
skip tests and later flutter version
bparrishMines Sep 5, 2024
55ee1fd
skip the correct test
bparrishMines Sep 5, 2024
c3b0bc3
Merge branch 'main' of github.com:flutter/packages into update_examples
bparrishMines Sep 5, 2024
56f2b1d
check for macos
bparrishMines Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/extension_google_sign_in_as_googleapis_auth/example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.4.2'
classpath 'com.android.tools.build:gradle:8.5.2'
classpath 'com.google.gms:google-services:4.3.15'
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/example/hello/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:8.1.0'
Copy link
Contributor

@reidbaker reidbaker Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmackall this change should not be required based on what I know about the reasons for having to update to at least agp 8.1 (androidx unpublished dependency).
Do you know why this update is required?

Copy link
Member

@gmackall gmackall Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the upgrade to this example shouldn't be necessary (just the upgrade that landed in https://github.com/flutter/packages/pull/7545/files), but also it doesn't hurt to have them all on the latest

Copy link
Contributor Author

@bparrishMines bparrishMines Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't required. I just updated since it was in the same package. I went ahead and reverted it. But I can upgrade if that is preferred.

classpath 'com.android.tools.build:gradle:8.5.2'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/example/local/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:8.5.1'
classpath 'com.android.tools.build:gradle:8.5.2'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand Down