-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs #6236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
31eb6cd
fix optionURLReflectsImperativeAPIs flag
strelas 182164e
fix optionURLReflectsImperativeAPIs flag x2
strelas 4bcaf1f
fix optionURLReflectsImperativeAPIs flag x3
strelas 3d643d9
fix
strelas f08a445
fix
strelas 7d2e95f
mb now
strelas cf3b47f
correct format
strelas 2b9991a
add test
strelas b80628e
Merge branch 'flutter:main' into main
anisovdev 69e8ff6
update CHANGELOG.md
strelas e5c4454
Merge remote-tracking branch 'origin/main'
strelas 57c4cf9
revert some unused changed
strelas d872c70
increase version
strelas a906a9b
correct package version in CHANGELOG.md
strelas a8a5ac3
Merge branch 'main' into main
anisovdev 867d01b
Merge branch 'main' into main
anisovdev e38431c
Merge branch 'main' into main
anisovdev 19e0e2d
Merge branch 'main' into main
anisovdev 27ec78a
Merge branch 'main' into main
anisovdev bddb3b0
Merge branch 'main' into main
anisovdev dc2a4e8
update package version
strelas 6389cee
Merge branch 'main' into main
anisovdev 9fd4736
Merge branch 'main' into main
anisovdev 42fc4b3
Merge branch 'main' into main
anisovdev ea4cc0c
Merge branch 'main' into main
anisovdev 6c24c2e
Merge branch 'main' into main
anisovdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This description sounds like you changed the "optionURLReflectsImperativeAPIs" flag. You can update the description like "Fixes
restoreRouteInformationissue when GoRouter.optionURLReflectsImperativeAPIs is true and the last match is ShellRouteMatch"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done