Skip to content

[ci] Introduce LUCI versions of Linux desktop platform tests #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 10 commits into from
Jul 15, 2023
Merged

[ci] Introduce LUCI versions of Linux desktop platform tests #4223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f156168
[ci] Introduce LUCI versions of Linux desktop tests
stuartmorgan-g Jun 15, 2023
732078c
Run Linux tests under xvfb, as in Cirrus
stuartmorgan-g Jun 16, 2023
017613a
Merge branch 'main' into luci-linux-desktop-initial
stuartmorgan-g Jul 6, 2023
ccf52b0
Try a script that sets defaults, just to see
stuartmorgan-g Jul 6, 2023
fffedc3
Merge branch 'main' into luci-linux-desktop-initial
stuartmorgan-g Jul 13, 2023
53e5446
Fix xdg-* commands
stuartmorgan-g Jul 13, 2023
426f9c8
Fix desktop file references
stuartmorgan-g Jul 13, 2023
207ac5f
Consistent bracing and quoting
stuartmorgan-g Jul 13, 2023
f204496
Undo hack for presubmit
stuartmorgan-g Jul 13, 2023
7113423
Missed bracing
stuartmorgan-g Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@ platform_properties:
linux:
properties:
os: Linux
linux_desktop:
properties:
os: Ubuntu
cores: "8"
device_type: none
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three lines are copied from the config that seems to be running these tests in flutter/flutter.

dependencies: >-
[
{"dependency": "clang", "version": "git_revision:5d5aba78dbbee75508f01bcaa69aedb2ab79065a"},
{"dependency": "cmake", "version": "build_id:8787856497187628321"},
{"dependency": "ninja", "version": "version:1.9.0"},
{"dependency": "curl", "version": "version:7.64.0"}
]
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are copied from the flutter/flutter dependencies list of the desktop tests.

In flutter/flutter these are on targets, not in platform_properties, but since we'll need these in several tests I put them in a new configuration up here instead. Is that the right way to do it? Is there best practice/guidance on when to do configs vs duplicating in targets?

Copy link
Contributor

@keyonghan keyonghan Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the preferred way to go. Define any shared properties in platform level if all tests need. If some specific test needs an extra property, then add that to the target level.

windows:
properties:
dependencies: >
Expand Down Expand Up @@ -48,7 +60,7 @@ platform_properties:
}

targets:
### Linux tasks ###
### Linux-host tasks ###
- name: Linux repo_tools_tests
recipe: packages/packages
timeout: 30
Expand All @@ -58,6 +70,44 @@ targets:
channel: master
version_file: flutter_master.version

### Linux desktop tasks
- name: Linux_desktop build_all_packages master
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
version_file: flutter_master.version
target_file: linux_build_all_packages.yaml
channel: master

- name: Linux_desktop build_all_packages stable
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
version_file: flutter_stable.version
target_file: linux_build_all_packages.yaml
channel: stable

- name: Linux_desktop platform_tests master
bringup: true # New target
recipe: packages/packages
timeout: 30
properties:
version_file: flutter_master.version
target_file: linux_platform_tests.yaml
channel: master

- name: Linux_desktop platform_tests stable
bringup: true # New target
recipe: packages/packages
presubmit: false
timeout: 30
properties:
version_file: flutter_stable.version
target_file: linux_platform_tests.yaml
channel: stable

### iOS+macOS tasks ###
# TODO(stuartmorgan): Move this to ARM once google_maps_flutter has ARM
# support. `pod lint` makes a synthetic target that doesn't respect the
Expand Down
11 changes: 11 additions & 0 deletions .ci/targets/linux_build_all_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
- name: create all_packages app
script: .ci/scripts/create_all_packages_app.sh
- name: build all_packages for Linux debug
script: .ci/scripts/build_all_packages_app.sh
args: ["linux", "debug"]
- name: build all_packages for Linux release
script: .ci/scripts/build_all_packages_app.sh
args: ["linux", "release"]
12 changes: 12 additions & 0 deletions .ci/targets/linux_platform_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
tasks:
- name: prepare tool
script: .ci/scripts/prepare_tool.sh
- name: build examples
script: script/tool_runner.sh
args: ["build-examples", "--linux"]
- name: native test
script: script/tool_runner.sh
args: ["native-test", "--linux"]
- name: drive examples
script: script/tool_runner.sh
args: ["drive-examples", "--linux", "--exclude=script/configs/exclude_integration_linux.yaml"]