Skip to content

[go_router] #127016 preserved route name case when caching _nameToPath #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Jun 13, 2023
Merged

[go_router] #127016 preserved route name case when caching _nameToPath #4196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ab3bc6
#127016 preserved route name case when caching `_nameToPath` by not u…
Khalidm98 Jun 12, 2023
5de2973
[go_router] #127016 updated version and changelog
Khalidm98 Jun 12, 2023
a281789
[go_router] #127016 added name_case_test
Khalidm98 Jun 12, 2023
0ad1569
Merge branch 'main' into main
Khalidm98 Jun 12, 2023
e4e8e67
[go_router] #127016 pulled main and resolved conflicts
Khalidm98 Jun 12, 2023
0e2286d
[go_router] #127016 added copyright and license text
Khalidm98 Jun 12, 2023
992bd3c
[go_router] #127016 removed navKey from test and used router and find…
Khalidm98 Jun 12, 2023
fd9d8db
[go_router] #127016 fixed failed tests
Khalidm98 Jun 13, 2023
1116926
[go_router] #127016 fixed format
Khalidm98 Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/go_router/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 8.0.2

- Preserves route name case when caching `_nameToPath` by not using `toLowerCase()`.<br>
this is useful to make route names case sensitive
Copy link
Contributor

@chunhtai chunhtai Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Preserves route name case when caching `_nameToPath` by not using `toLowerCase()`.<br>
this is useful to make route names case sensitive
- Makes namedLocation and route name related APIs case sensitive.

Copy link
Contributor Author

@Khalidm98 Khalidm98 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will write the test

Copy link
Contributor Author

@Khalidm98 Khalidm98 Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the test and modified the changelog as suggested.
Do you have any other comments or suggestions in mind?
Thanks ✌️


## 8.0.1

- Fixes a link for an example in `path` documentation.
Expand Down
4 changes: 2 additions & 2 deletions packages/go_router/lib/src/configuration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class RouteConfiguration {
'${queryParameters.isEmpty ? '' : ', queryParameters: $queryParameters'}');
return true;
}());
final String keyName = name.toLowerCase();
final String keyName = name;
assert(_nameToPath.containsKey(keyName), 'unknown route name: $name');
final String path = _nameToPath[keyName]!;
assert(() {
Expand Down Expand Up @@ -564,7 +564,7 @@ class RouteConfiguration {
final String fullPath = concatenatePaths(parentFullPath, route.path);

if (route.name != null) {
final String name = route.name!.toLowerCase();
final String name = route.name!;
assert(
!_nameToPath.containsKey(name),
'duplication fullpaths for name '
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 8.0.1
version: 8.0.2
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down