Skip to content

[image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmagman merged 1 commit into from
Apr 21, 2023
Merged

[image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property #3783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/image_picker/image_picker_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## NEXT
* Updates metadata unit test to work on iOS 16.2.

## 0.8.7+3

* Updates pigeon to fix warnings with clang 15.
Expand Down
4 changes: 2 additions & 2 deletions packages/image_picker/image_picker_ios/example/ios/RunnerTests/PhotoAssetUtilTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ - (void)testSaveImageWithPickerInfo_ShouldSaveWithTheCorrectExtentionAndMetaData
NSDictionary *dummyInfo = @{
UIImagePickerControllerMediaMetadata : @{
(__bridge NSString *)kCGImagePropertyExifDictionary :
@{(__bridge NSString *)kCGImagePropertyExifMakerNote : @"aNote"}
@{(__bridge NSString *)kCGImagePropertyExifUserComment : @"aNote"}
}
};
UIImage *imageJPG = [UIImage imageWithData:ImagePickerTestImages.JPGTestData];
Expand All @@ -86,7 +86,7 @@ - (void)testSaveImageWithPickerInfo_ShouldSaveWithTheCorrectExtentionAndMetaData
NSData *data = [NSData dataWithContentsOfFile:savedPathJPG];
NSDictionary *meta = [FLTImagePickerMetaDataUtil getMetaDataFromImageData:data];
XCTAssertEqualObjects(meta[(__bridge NSString *)kCGImagePropertyExifDictionary]
[(__bridge NSString *)kCGImagePropertyExifMakerNote],
[(__bridge NSString *)kCGImagePropertyExifUserComment],
@"aNote");
}

Expand Down