Skip to content

Conversation

@Harishwarrior
Copy link
Contributor

@Harishwarrior Harishwarrior commented Apr 11, 2023

This PR fixes the issue where running the example app present in flutter_adaptive_scaffold in Android is not working due to package name not present in AndroidManifest file.

fixes: flutter/flutter#124600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gspencergoog
Copy link
Contributor

@Harishwarrior Can you please request a test exemption as the bot's message above describes? This PR may be eligible for that.

@Harishwarrior
Copy link
Contributor Author

@Harishwarrior Can you please request a test exemption as the bot's message above describes? This PR may be eligible for that.

Just did that now. Waiting for his response.

@Hixie
Copy link
Contributor

Hixie commented Apr 11, 2023

test-exempt: the cost of testing the examples run on every platform is disproportionate to the benefit.

@Harishwarrior
Copy link
Contributor Author

@Harishwarrior Can you please request a test exemption as the bot's message above describes? This PR may be eligible for that.

Done.

@Harishwarrior Harishwarrior force-pushed the main branch 2 times, most recently from cbd0575 to 2e3cd9f Compare April 12, 2023 10:08
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@gspencergoog
Copy link
Contributor

@reidbaker the change in #3574 seems to have removed the package from this manifest. Was that intended, and is putting it back undoing what you were trying to do?

@reidbaker
Copy link
Contributor

reidbaker commented Apr 12, 2023

The package is now defined in the build.gradle. Please don't add this back in the manifest

@gspencergoog
Copy link
Contributor

gspencergoog commented Apr 12, 2023

Okay, closing. Can you comment on the issue to indicate what the correct fix is?

flutter/flutter#124600

@chunhtai chunhtai removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@reidbaker reidbaker self-requested a review April 12, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_adaptive_scaffold] : Example app is not running in Android

5 participants