-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[flutter_adaptive_scaffold] : Fixed example app not running in Android platform #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Harishwarrior Can you please request a test exemption as the bot's message above describes? This PR may be eligible for that. |
Just did that now. Waiting for his response. |
|
test-exempt: the cost of testing the examples run on every platform is disproportionate to the benefit. |
Done. |
cbd0575 to
2e3cd9f
Compare
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@reidbaker the change in #3574 seems to have removed the package from this manifest. Was that intended, and is putting it back undoing what you were trying to do? |
|
The package is now defined in the build.gradle. Please don't add this back in the manifest |
|
Okay, closing. Can you comment on the issue to indicate what the correct fix is? |

This PR fixes the issue where running the example app present in flutter_adaptive_scaffold in Android is not working due to package name not present in AndroidManifest file.
fixes: flutter/flutter#124600
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.