[espresso] Enable warnings as errors

packages/espresso/CHANGELOG.md

@@ -1,6 +1,7 @@
-## NEXT
+## 0.2.1+1
 
 * Aligns Dart and Flutter SDK constraints.
+* Changes the severity of `javac` warnings so that they are treated as errors and fixes the violations.
 
 ## 0.2.1
 

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/EspressoFlutter.java

@@ -137,7 +137,7 @@ private <T> T performInternal(FlutterAction<T> flutterAction) {
           "The action cannot be null. You must specify an action to perform on the matched"
               + " Flutter widget.");
       FlutterViewAction<T> flutterViewAction =
-          new FlutterViewAction(
+          new FlutterViewAction<>(
               widgetMatcher, flutterAction, okHttpClient, idGenerator, taskExecutor);
       onView(flutterViewMatcher).perform(flutterViewAction);
       T result;

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/action/FlutterViewAction.java

@@ -13,7 +13,7 @@
 
 import android.os.Looper;
 import android.view.View;
-import androidx.test.annotation.Beta;
+import androidx.test.annotation.ExperimentalTestApi;
 import androidx.test.espresso.IdlingRegistry;
 import androidx.test.espresso.IdlingResource;
 import androidx.test.espresso.UiController;
@@ -47,7 +47,7 @@
  * <p>This class acts as a bridge to perform {@code WidgetAction} on a Flutter widget on the given
  * {@code FlutterView}.
  */
-@Beta
+@ExperimentalTestApi
 public final class FlutterViewAction<T> implements ViewAction {
 
   private static final String FLUTTER_IDLE_TASK_NAME = "flutterIdlingResource";
@@ -105,7 +105,7 @@ public void perform(UiController uiController, View flutterView) {
     // The url {@code FlutterNativeView} returns is the http url that the Dart VM Observatory http
     // server serves at. Need to convert to the one that the WebSocket uses.
     URI dartVmServiceProtocolUrl =
-        DartVmServiceUtil.getServiceProtocolUri(FlutterJNI.getObservatoryUri());
+        DartVmServiceUtil.getServiceProtocolUri(FlutterJNI.getVMServiceUri());
     String isolateId = DartVmServiceUtil.getDartIsolateId(flutterView);
     final FlutterTestingProtocol flutterTestingProtocol =
         new DartVmService(

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/action/SyntheticClickAction.java

@@ -5,7 +5,7 @@
 package androidx.test.espresso.flutter.action;
 
 import android.view.View;
-import androidx.test.annotation.Beta;
+import androidx.test.annotation.ExperimentalTestApi;
 import androidx.test.espresso.UiController;
 import androidx.test.espresso.flutter.api.FlutterTestingProtocol;
 import androidx.test.espresso.flutter.api.SyntheticAction;
@@ -21,7 +21,7 @@
  * <p>Note, this is not a real click gesture event issued from Android system. Espresso delegates to
  * Flutter engine to perform the {@link SyntheticClick} action.
  */
-@Beta
+@ExperimentalTestApi
 public final class SyntheticClickAction implements WidgetAction {
 
   @Override

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/exception/AmbiguousWidgetMatcherException.java

@@ -13,6 +13,8 @@
 public final class AmbiguousWidgetMatcherException extends RuntimeException
     implements EspressoException {
 
+  private static final long serialVersionUID = 9000L;
+
   public AmbiguousWidgetMatcherException(String message) {
     super(message);
   }

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/exception/InvalidFlutterViewException.java

@@ -10,6 +10,8 @@
 public final class InvalidFlutterViewException extends RuntimeException
     implements EspressoException {
 
+  private static final long serialVersionUID = 9001L;
+
   /** Constructs with an error message. */
   public InvalidFlutterViewException(String message) {
     super(message);

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/exception/NoMatchingWidgetException.java

@@ -11,6 +11,7 @@
  * hierarchy.
  */
 public final class NoMatchingWidgetException extends RuntimeException implements EspressoException {
+  private static final long serialVersionUID = 9002L;
 
   public NoMatchingWidgetException(String message) {
     super(message);

packages/espresso/android/src/main/java/androidx/test/espresso/flutter/internal/protocol/impl/FlutterProtocolException.java

@@ -6,6 +6,7 @@
 
 /** Represents an exception/error relevant to Dart VM service. */
 public final class FlutterProtocolException extends RuntimeException {
+  private static final long serialVersionUID = 8999L;
 
   public FlutterProtocolException(String message) {
     super(message);

packages/espresso/example/android/build.gradle

@@ -35,9 +35,7 @@ task clean(type: Delete) {
 gradle.projectsEvaluated {
     project(":espresso") {
         tasks.withType(JavaCompile) {
-            // TODO(stuartmorgan): Enable this. See
-            // https://github.com/flutter/flutter/issues/91868
-            //options.compilerArgs << "-Xlint:all" << "-Werror"
+            options.compilerArgs << "-Xlint:all" << "-Werror"
         }
     }
 }

packages/espresso/pubspec.yaml

@@ -3,7 +3,7 @@ description: Java classes for testing Flutter apps using Espresso.
   Allows driving Flutter widgets from a native Espresso test.
 repository: https://github.com/flutter/packages/tree/main/packages/espresso
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22
-version: 0.2.1
+version: 0.2.1+1
 
 environment:
   sdk: ">=2.17.0 <3.0.0"