-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[shared_preferences] Ports SharedPreferencesAndroid to Pigeon #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 22 commits into
flutter:main
from
AmanNegi:port-sharedprefs-android-to-pigeon
Apr 13, 2023
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f8260d7
Recreating PR from flutter/plugins
AmanNegi 312dce7
Merge branch 'main' of github.com:flutter/packages into port-sharedpr…
tarrinneal 211b2cf
update to latest api
tarrinneal 11a0ae8
update to latest api, add integration tests
tarrinneal f6a7cdd
Merge branch 'main' of github.com:flutter/packages into port-sharedpr…
tarrinneal 48c9cd9
fix tests?
tarrinneal 366a405
some mocking, but no testing
tarrinneal 7b825a7
tests work, but some fail (commented out) WIP
tarrinneal a37f155
fix tests, no string lists
tarrinneal f2fffa9
listEncoder
tarrinneal c3ac1b9
Merge branch 'main' of github.com:flutter/packages into port-sharedpr…
tarrinneal 03dedc3
format
tarrinneal 1dfb1e7
formatting
tarrinneal b7dfefa
import nonnull
tarrinneal f11df81
Every thing in the world is now nonnull
tarrinneal 50e4b8c
format
tarrinneal 56518bf
most nits (still need to merge files)
tarrinneal 279ec4a
merge files
tarrinneal 4872c06
comments and tests
tarrinneal 5b34294
format pigeons (it's good for their health)
tarrinneal deb7e49
nits
tarrinneal 403826c
final nits
tarrinneal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/shared_preferences/shared_preferences_android/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 0 additions & 133 deletions
133
...oid/android/src/main/java/io/flutter/plugins/sharedpreferences/MethodCallHandlerImpl.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.