flutter · stuartmorgan-g · Mar 2, 2023 · Feb 24, 2023 · Feb 24, 2023 · Feb 24, 2023
@@ -14,6 +14,19 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":camera_android") {
+            tasks.withType(JavaCompile) {
+                // TODO(stuartmorgan): Enable this. See
+                // https://github.com/flutter/flutter/issues/91868
+                //options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -120,9 +120,7 @@ public Long bindToLifecycle(
                   instanceManager.getInstance(((Number) useCaseIds.get(i)).longValue()));
     }
 
-    Camera camera =
-        processCameraProvider.bindToLifecycle(
-            (LifecycleOwner) lifecycleOwner, cameraSelector, useCases);
+    Camera camera = processCameraProvider.bindToLifecycle(lifecycleOwner, cameraSelector, useCases);
 
     final CameraFlutterApiImpl cameraFlutterApi =
         new CameraFlutterApiImpl(binaryMessenger, instanceManager);

@@ -16,6 +16,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":camera_android_camerax") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -14,6 +14,19 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":espresso") {
+            tasks.withType(JavaCompile) {
+                // TODO(stuartmorgan): Enable this. See
+                // https://github.com/flutter/flutter/issues/91868
+                //options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":flutter_plugin_android_lifecycle") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -1,3 +1,7 @@
+## 2.4.7
+
+* Fixes compilation warnings.
+
 ## 2.4.6
 
 * Updates links for the merge of flutter/plugins into flutter/packages.

@@ -25,7 +25,6 @@
 import com.google.android.gms.maps.model.RoundCap;
 import com.google.android.gms.maps.model.SquareCap;
 import com.google.android.gms.maps.model.Tile;
-import io.flutter.view.FlutterMain;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -50,15 +49,16 @@ private static BitmapDescriptor toBitmapDescriptor(Object o) {
       case "fromAsset":
         if (data.size() == 2) {
           return BitmapDescriptorFactory.fromAsset(
-              FlutterMain.getLookupKeyForAsset(toString(data.get(1))));
+              io.flutter.view.FlutterMain.getLookupKeyForAsset(toString(data.get(1))));
         } else {
           return BitmapDescriptorFactory.fromAsset(
-              FlutterMain.getLookupKeyForAsset(toString(data.get(1)), toString(data.get(2))));
+              io.flutter.view.FlutterMain.getLookupKeyForAsset(
+                  toString(data.get(1)), toString(data.get(2))));
         }
       case "fromAssetImage":
         if (data.size() == 3) {
           return BitmapDescriptorFactory.fromAsset(
-              FlutterMain.getLookupKeyForAsset(toString(data.get(1))));
+              io.flutter.view.FlutterMain.getLookupKeyForAsset(toString(data.get(1))));
         } else {
           throw new IllegalArgumentException(
               "'fromAssetImage' Expected exactly 3 arguments, got: " + data.size());

@@ -14,6 +14,19 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":google_maps_flutter_android") {
+            tasks.withType(JavaCompile) {
+                // TODO(stuartmorgan): Enable this. See
+                // https://github.com/flutter/flutter/issues/91868
+                //options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -2,7 +2,7 @@ name: google_maps_flutter_android
 description: Android implementation of the google_maps_flutter plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
-version: 2.4.6
+version: 2.4.7
 
 environment:
   sdk: ">=2.14.0 <3.0.0"

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":google_sign_in_android") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -1,3 +1,7 @@
+## 0.8.5+8
+
+* Fixes compilation warnings.
+
 ## 0.8.5+7
 
 * Updates links for the merge of flutter/plugins into flutter/packages.

@@ -29,12 +29,6 @@
 import java.util.Map;
 import java.util.UUID;
 
-enum CameraDevice {
-  REAR,
-
-  FRONT
-}
-
 /**
  * A delegate class doing the heavy lifting for the plugin.
  *
@@ -83,6 +77,11 @@ public class ImagePickerDelegate
   @VisibleForTesting static final int REQUEST_CODE_TAKE_VIDEO_WITH_CAMERA = 2353;
   @VisibleForTesting static final int REQUEST_CAMERA_VIDEO_PERMISSION = 2355;
 
+  public enum CameraDevice {
+    REAR,
+    FRONT
+  }
+
   @VisibleForTesting final String fileProviderName;
 
   private final Activity activity;
@@ -219,21 +218,22 @@ void saveStateBeforeResult() {
   void retrieveLostImage(MethodChannel.Result result) {
     Map<String, Object> resultMap = cache.getCacheMap();
     @SuppressWarnings("unchecked")
-    ArrayList<String> pathList = (ArrayList<String>) resultMap.get(cache.MAP_KEY_PATH_LIST);
+    ArrayList<String> pathList =
+        (ArrayList<String>) resultMap.get(ImagePickerCache.MAP_KEY_PATH_LIST);
     ArrayList<String> newPathList = new ArrayList<>();
     if (pathList != null) {
       for (String path : pathList) {
-        Double maxWidth = (Double) resultMap.get(cache.MAP_KEY_MAX_WIDTH);
-        Double maxHeight = (Double) resultMap.get(cache.MAP_KEY_MAX_HEIGHT);
+        Double maxWidth = (Double) resultMap.get(ImagePickerCache.MAP_KEY_MAX_WIDTH);
+        Double maxHeight = (Double) resultMap.get(ImagePickerCache.MAP_KEY_MAX_HEIGHT);
         int imageQuality =
-            resultMap.get(cache.MAP_KEY_IMAGE_QUALITY) == null
+            resultMap.get(ImagePickerCache.MAP_KEY_IMAGE_QUALITY) == null
                 ? 100
-                : (int) resultMap.get(cache.MAP_KEY_IMAGE_QUALITY);
+                : (int) resultMap.get(ImagePickerCache.MAP_KEY_IMAGE_QUALITY);
 
         newPathList.add(imageResizer.resizeImageIfNeeded(path, maxWidth, maxHeight, imageQuality));
       }
-      resultMap.put(cache.MAP_KEY_PATH_LIST, newPathList);
-      resultMap.put(cache.MAP_KEY_PATH, newPathList.get(newPathList.size() - 1));
+      resultMap.put(ImagePickerCache.MAP_KEY_PATH_LIST, newPathList);
+      resultMap.put(ImagePickerCache.MAP_KEY_PATH, newPathList.get(newPathList.size() - 1));
     }
     if (resultMap.isEmpty()) {
       result.success(null);

@@ -342,12 +342,12 @@ public void onMethodCall(MethodCall call, MethodChannel.Result rawResult) {
     int imageSource;
     ImagePickerDelegate delegate = activityState.getDelegate();
     if (call.argument("cameraDevice") != null) {
-      CameraDevice device;
+      ImagePickerDelegate.CameraDevice device;
       int deviceIntValue = call.argument("cameraDevice");
       if (deviceIntValue == CAMERA_DEVICE_FRONT) {
-        device = CameraDevice.FRONT;
+        device = ImagePickerDelegate.CameraDevice.FRONT;
       } else {
-        device = CameraDevice.REAR;
+        device = ImagePickerDelegate.CameraDevice.REAR;
       }
       delegate.setCameraDevice(device);
     }

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":image_picker_android") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -2,7 +2,7 @@ name: image_picker_android
 description: Android implementation of the image_picker plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/image_picker/image_picker_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
-version: 0.8.5+7
+version: 0.8.5+8
 
 environment:
   sdk: ">=2.14.0 <3.0.0"

@@ -14,6 +14,19 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":in_app_purchase_android") {
+            tasks.withType(JavaCompile) {
+                // TODO(stuartmorgan): Enable this. See
+                // https://github.com/flutter/flutter/issues/91868
+                //options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -1,3 +1,7 @@
+## 1.0.20
+
+* Fixes compilation warnings.
+
 ## 1.0.19
 
 * Updates links for the merge of flutter/plugins into flutter/packages.

@@ -26,7 +26,6 @@
 import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
 import io.flutter.plugin.common.MethodChannel.Result;
 import io.flutter.plugin.common.PluginRegistry;
-import io.flutter.plugin.common.PluginRegistry.Registrar;
 import io.flutter.plugins.localauth.AuthenticationHelper.AuthCompletionHandler;
 import java.util.ArrayList;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -78,7 +77,7 @@ public boolean onActivityResult(int requestCode, int resultCode, Intent data) {
    *     io.flutter.plugin.common.BinaryMessenger}.
    */
   @SuppressWarnings("deprecation")
-  public static void registerWith(Registrar registrar) {
+  public static void registerWith(PluginRegistry.Registrar registrar) {
     final MethodChannel channel = new MethodChannel(registrar.messenger(), CHANNEL_NAME);
     final LocalAuthPlugin plugin = new LocalAuthPlugin();
     plugin.activity = registrar.activity();

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":local_auth_android") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -2,7 +2,7 @@ name: local_auth_android
 description: Android implementation of the local_auth plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/local_auth/local_auth_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+local_auth%22
-version: 1.0.19
+version: 1.0.20
 
 environment:
   sdk: ">=2.14.0 <3.0.0"

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":path_provider_android") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'

@@ -14,6 +14,17 @@ allprojects {
         google()
         mavenCentral()
     }
+    // Build the plugin project with warnings enabled. This is here rather than
+    // in the plugin itself to avoid breaking clients that have different
+    // warnings (e.g., deprecation warnings from a newer SDK than this project
+    // builds with).
+    gradle.projectsEvaluated {
+        project(":quick_actions_android") {
+            tasks.withType(JavaCompile) {
+                options.compilerArgs << "-Xlint:all" << "-Werror"
+            }
+        }
+    }
 }
 
 rootProject.buildDir = '../build'