Skip to content

[go_router_builder] Fix the example for default values in the README #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 4 commits into from
Mar 2, 2023
Merged

[go_router_builder] Fix the example for default values in the README #3231

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b20c749
docs: Fix the example for default values
ValentinVignal Feb 21, 2023
0c421b1
docs: Increase version number
ValentinVignal Feb 21, 2023
8379db6
Merge branch 'main' into go-router-builder/fix-example-for-default-va…
ValentinVignal Feb 23, 2023
fd8d9c9
Merge remote-tracking branch 'upstream/main' into go-router-builder/f…
ValentinVignal Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.1.2

* Fixes the example for the default values in the README.

## 1.1.1

* Support for the generation of the pushReplacement method has been added.
Expand Down
4 changes: 2 additions & 2 deletions packages/go_router_builder/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,10 @@ For query parameters with a **non-nullable** type, you can define a default valu
```dart
class MyRoute extends GoRouteData {
MyRoute({this.queryParameter = 'defaultValue'});
final String from;
final String queryParameter;

@override
Widget build(BuildContext context, GoRouterState state) => MyScreen(from: from);
Widget build(BuildContext context, GoRouterState state) => MyScreen(queryParameter: queryParameter);
}
```

Expand Down
2 changes: 1 addition & 1 deletion packages/go_router_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 1.1.1
version: 1.1.2
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand Down