[video_player] : Add video track selection support for Android and iOS #10688

nateshmbhat · 2025-12-27T16:04:28Z

This PR adds video track selection (quality switching) support to the video_player plugin for Android and iOS platforms. This allows users to programmatically get available video quality variants and select a specific quality track, similar to the existing audio track selection feature.

Addresses issue : flutter/flutter#58854

Pre-Review Checklist

gemini-code-assist

Code Review

This pull request introduces video track (quality) selection support for Android and iOS in the video_player plugin. It adds getVideoTracks, selectVideoTrack, and isVideoTrackSupportAvailable methods to the VideoPlayerController and the platform interface. The Android implementation leverages ExoPlayer's track selection, including a workaround for resolution changes, while the iOS implementation uses AVAssetVariant for iOS 15+ and preferredPeakBitRate. The web platform includes stub implementations since the feature is not supported there. The changes are well-structured, with corresponding updates to the example app and comprehensive tests. I have one suggestion to improve the example app's robustness by avoiding the use of BuildContext across asynchronous gaps.

gemini-code-assist · 2025-12-27T16:08:32Z

packages/video_player/video_player/example/lib/video_tracks_demo.dart

+  Future<void> _selectVideoTrack(VideoTrack? track) async {
+    final VideoPlayerController? controller = _controller;
+    if (controller == null) {
+      return;
+    }
+
+    try {
+      await controller.selectVideoTrack(track);
+
+      setState(() {
+        _isAutoQuality = track == null;
+      });
+
+      // Reload tracks to update selection status
+      await _loadVideoTracks();
+
+      if (!mounted) {
+        return;
+      }
+      final String message = track == null
+          ? 'Switched to automatic quality'
+          : 'Selected video track: ${_getTrackLabel(track)}';
+      ScaffoldMessenger.of(context).showSnackBar(SnackBar(content: Text(message)));
+    } catch (e) {
+      if (!mounted) {
+        return;
+      }
+      ScaffoldMessenger.of(
+        context,
+      ).showSnackBar(SnackBar(content: Text('Failed to select video track: $e')));
+    }
+  }


Avoid using BuildContext across asynchronous gaps. The context might be invalid after an await. It's safer to get a reference to ScaffoldMessenger before the async calls.

Future<void> _selectVideoTrack(VideoTrack? track) async { final VideoPlayerController? controller = _controller; if (controller == null) { return; } final ScaffoldMessengerState scaffoldMessenger = ScaffoldMessenger.of(context); try { await controller.selectVideoTrack(track); setState(() { _isAutoQuality = track == null; }); // Reload tracks to update selection status await _loadVideoTracks(); if (!mounted) { return; } final String message = track == null ? 'Switched to automatic quality' : 'Selected video track: ${_getTrackLabel(track)}'; scaffoldMessenger.showSnackBar(SnackBar(content: Text(message))); } catch (e) { if (!mounted) { return; } scaffoldMessenger .showSnackBar(SnackBar(content: Text('Failed to select video track: $e'))); } }

hellohuanlin

thanks for the contribution. this seems like a useful feature. left some comments on iOS part.

packages/video_player/video_player/CHANGELOG.md

hellohuanlin · 2026-01-05T18:25:04Z

packages/video_player/video_player/example/ios/Podfile

@@ -1,5 +1,5 @@
 # Uncomment this line to define a global platform for your project
-# platform :ios, '12.0'
+# platform :ios, '13.0'


is this change expected? cc @vashworth

packages/video_player/video_player/example/lib/main.dart

hellohuanlin · 2026-01-05T18:25:50Z

packages/video_player/video_player/example/macos/Podfile

@@ -1,4 +1,4 @@
-platform :osx, '10.14'
+platform :osx, '10.15'


also this change

packages/video_player/video_player/lib/video_player.dart

...undation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPVideoPlayer.m

nateshmbhat · 2026-01-07T16:39:56Z

@hellohuanlin Thanks for the review. have addressed your comments 🙏🏻

LouiseHsu · 2026-01-07T20:47:03Z

packages/video_player/video_player/pubspec.yaml

+  video_player_platform_interface:
+    path: ../video_player_platform_interface
+  video_player_web:
+    path: ../video_player_web


I don't think these changes are correct. We can't pin dependencies to a local path in pubspec.yaml - they must be pinned to published versions. Otherwise, pub publish will reject the package.

btw to test stuff locally, you can try using a pubspec_overrides.yaml which is gitignored, but will still let you use your local changes.

https://dart.dev/tools/pub/dependencies#pubspec-overrides

LouiseHsu · 2026-01-07T20:47:23Z

packages/video_player/video_player_android/example/pubspec.yaml

    # the parent directory to use the current plugin's version.
    path: ../
-  video_player_platform_interface: ^6.6.0
+  video_player_platform_interface:


same comment as my above pubspec comment

LouiseHsu · 2026-01-07T20:47:31Z

packages/video_player/video_player_android/pubspec.yaml

  flutter:
    sdk: flutter
-  video_player_platform_interface: ^6.6.0
+  video_player_platform_interface:


LouiseHsu · 2026-01-07T20:47:45Z

packages/video_player/video_player_avfoundation/example/pubspec.yaml

    # the parent directory to use the current plugin's version.
    path: ../
-  video_player_platform_interface: ^6.3.0
+  video_player_platform_interface:


LouiseHsu · 2026-01-07T20:48:04Z

packages/video_player/video_player_avfoundation/pubspec.yaml

  flutter:
    sdk: flutter
-  video_player_platform_interface: ^6.3.0
+  video_player_platform_interface:


LouiseHsu · 2026-01-07T20:48:10Z

packages/video_player/video_player_web/example/pubspec.yaml

  flutter:
    sdk: flutter
-  video_player_platform_interface: ^6.3.0
+  video_player_platform_interface:


LouiseHsu · 2026-01-07T20:48:18Z

packages/video_player/video_player_web/pubspec.yaml

  flutter_web_plugins:
    sdk: flutter
-  video_player_platform_interface: ^6.4.0
+  video_player_platform_interface:


nateshmbhat added 2 commits December 27, 2025 20:50

Adds video track selection feature. implemented for android

4540ac7

feat(ios) : adds ios implementation for selecting video track

3662630

nateshmbhat requested review from LouiseHsu, hellohuanlin, mboetger, mdebbar and tarrinneal as code owners December 27, 2025 16:04

github-actions bot added platform-android platform-ios platform-macos platform-web p: video_player labels Dec 27, 2025

gemini-code-assist bot reviewed Dec 27, 2025

View reviewed changes

nateshmbhat added 2 commits December 27, 2025 21:42

formatted the files

19fbb6f

fixed analysis errors

6980c13

hellohuanlin reviewed Jan 5, 2026

View reviewed changes

mdebbar removed their request for review January 6, 2026 20:28

nateshmbhat added 3 commits January 7, 2026 21:39

formatted all dart files

57f9b9a

addressed some PR comments

5c06f47

addressed pr comments

15d211f

Merge branch 'main' into feature/video-track-selection-v2

febcb8c

nateshmbhat requested a review from hellohuanlin January 7, 2026 16:54

LouiseHsu requested changes Jan 7, 2026

View reviewed changes

[video_player] : Add video track selection support for Android and iOS #10688

Are you sure you want to change the base?

[video_player] : Add video track selection support for Android and iOS #10688

Uh oh!

Conversation

nateshmbhat commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nateshmbhat commented Jan 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nateshmbhat commented Dec 27, 2025 •

edited

Loading